Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose universe plotting for the cell class #2648

Merged
merged 2 commits into from
Aug 20, 2023

Conversation

pshriwise
Copy link
Contributor

Description

Quality of life PR here allowing us to access the openmc.Universe.plot functionality from the Cell class. This PR provides the same functionality to the Cell class by creating a single-cell universe in the method and forwarding arguments to Universe.plot.

Screenshot 2023-08-13 at 3 16 16 PM

Checklist

  • I have performed a self-review of my own code
  • I have followed the style guidelines for Python source files (if applicable)

@paulromano paulromano linked an issue Aug 19, 2023 that may be closed by this pull request
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea, thanks @pshriwise!

@paulromano paulromano enabled auto-merge (squash) August 19, 2023 20:46
@paulromano paulromano merged commit 8e77a1f into openmc-dev:develop Aug 20, 2023
@shimwell
Copy link
Member

Would it be acceptable to follow up this PR with the same plot functionality on model.Geometry as currently I'm accessing the root_universe and plotting that model.geometry.root_universe.plot() and I would be keen to operator on the model.Geometry.plot()

@paulromano
Copy link
Contributor

@shimwell Yup, good idea 👍

stchaker pushed a commit to stchaker/openmc that referenced this pull request Oct 25, 2023
@pshriwise pshriwise mentioned this pull request Mar 6, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot cells
3 participants