Decodes traction request and reply messages for the monitor window #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a rounding problem in the LSB when conmvertingvalue from double.
Adds support for UInt24 parsing and rendering.
Adds unit tests for set/get speed, function and estop commands.
Adds unit tests for traction reply class.
…o the speed versionedvalue.
balazsracz
added a commit
that referenced
this pull request
Mar 7, 2022
# By Balazs Racz (3) and dependabot[bot] (1) # Via GitHub * 'master' of github.com:openlcb/OpenLCB_Java: Decodes traction request and reply messages for the monitor window (#195) Adds keyboard navigation between segments (#192) Prevents creating two loadingListeners. (#193) Bump xercesImpl from 2.12.0 to 2.12.2 (#190) # Conflicts: # src/org/openlcb/cdi/swing/CdiPanel.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds toString() methods to the TractionControlRequest and TractionControlReply messages. These tostring methods are used by the OpenLCB/LCC monitor log in JMRI. The decoding interprets the message command, subcommand and renders the arguments in text form.
Adds unit tests for untested parts of the traction messages, including creators and accessors.
Adds a few missing details from the TractionWM to the traction request/reply classes.
Misc supporting changes: