Prevents creating two loadingListeners. #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In one of the two typical paths the displayLoadingProgress is called twice. If we create two loadingListeners, we leak one and this causes the CdiPanel to be never garbage collected. As a result the java VM heap grows a lot and eventually JMRI crashes with out of memory.
pabender
approved these changes
Feb 15, 2022
balazsracz
added a commit
that referenced
this pull request
Mar 7, 2022
# By Balazs Racz (3) and dependabot[bot] (1) # Via GitHub * 'master' of github.com:openlcb/OpenLCB_Java: Decodes traction request and reply messages for the monitor window (#195) Adds keyboard navigation between segments (#192) Prevents creating two loadingListeners. (#193) Bump xercesImpl from 2.12.0 to 2.12.2 (#190) # Conflicts: # src/org/openlcb/cdi/swing/CdiPanel.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of the two typical paths the displayLoadingProgress is called twice.
If we create two loadingListeners, we leak one and this causes the CdiPanel
to be never garbage collected. As a result the java VM heap grows a lot and
eventually JMRI crashes with out of memory.