Use GroundPrimitive for line #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oterral
force-pushed
the
teo_lineclamp
branch
from
5d96375 to
77a5668
Compare
gberaudo
requested changes
Feb 2, 2017
| var outlinePrimitive; | ||
| var heightReference = this.getHeightReference(layer, feature, olGeometry); | ||
|
|
||
| if (heightReference == Cesium.HeightReference.CLAMP_TO_GROUND) { |
There was a problem hiding this comment.
If the positions are 3D (just test the first one), could you disregard the CLAMP_TO_GROUND height reference?
There was a problem hiding this comment.
You mean if the coordinates is x,y,z. we deactivate the clampToGround?
There was a problem hiding this comment.
We don't do this for polygons why doing it for lines ? and that doesn't make sense if the user specify clampToGround he expects the data are clamped to ground whatever the z value.
There was a problem hiding this comment.
OK, I checked the KML documentation and they do like you propose: https://developers.google.com/kml/documentation/altitudemode. So OK to merge. However, please update the README.md.
oterral
force-pushed
the
teo_lineclamp
branch
from
77a5668 to
5b99c1b
Compare
gberaudo
approved these changes
Feb 3, 2017
|
Thanks @oterral. |
|
Thx for the review @gberaudo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It corresponds to the hack in Cesium.KmlDataSource.