Update Cesium private variables in render loop #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To test, turn on the render loop in any example:
Then watch the CPU usage of the tab in Chrome's task manager. Previously the tab would be spinning on the caught error, now it should drop to ~0%. |
4 tasks
gberaudo
approved these changes
Jan 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the tile checks in
olcs.AutoRenderLoop#postRenderto match those used inCesium.Camera#update. Considered using the_suspendTerrainAdjustmentprivate flag in the Cesium camera, but that seemed more fragile to change and less clear to someone trying to understand the olcs code.