Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto render loop references old Cesium private variables #432

Closed
schmidtk opened this issue Jan 13, 2017 · 3 comments
Closed

Auto render loop references old Cesium private variables #432

schmidtk opened this issue Jan 13, 2017 · 3 comments

Comments

@schmidtk
Copy link
Contributor

If the auto render loop is enabled, it will constantly throw errors due to referencing surface._tileLoadQueue, which no longer exists in Cesium.

To reproduce, load the ol3cesium example, then start the render loop:

ol3d.enableAutoRenderLoop()

Break on caught exceptions and you'll see the problem. It looks like there is now a _tileLoadQueue[High|Medium|Low], so it will hopefully be as simple as checking all three.

@gberaudo
Copy link
Member

Thanks for the report. Are you willing to create a PR with the fix?

@schmidtk
Copy link
Contributor Author

I probably won't get to it until next week given my current work load, but I could submit a PR for it then.

@schmidtk
Copy link
Contributor Author

@gberaudo Sorry for the delay - had some app release work to finish first. PR is ready when you have a moment to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants