Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discourage/prevent image insertion without alt text #118

Closed
boonebgorges opened this issue May 1, 2018 · 6 comments
Closed

Discourage/prevent image insertion without alt text #118

boonebgorges opened this issue May 1, 2018 · 6 comments
Assignees
@boonebgorges @jennaspevack
Labels
needs-design
Milestone
Fall 2018

Comments

@boonebgorges
Copy link
Collaborator

Previously: #107
@boonebgorges boonebgorges added this to the Fall 2018 milestone May 1, 2018
@boonebgorges boonebgorges self-assigned this May 1, 2018
@boonebgorges
Copy link
Collaborator Author

This turns out to be a moderately difficult technical task. I've attached a gif of a first pass at an error workflow. If we think that some version of this is worth doing, the next step is likely for @jennaspevack to make some suggestions about better styling/wording.

peek 2018-05-01 14-05

boonebgorges added a commit that referenced this issue May 1, 2018
@boonebgorges
Initial pass at alt-text requirement.
b51c481 
See #118.
@boonebgorges
Copy link
Collaborator Author

(I've pulled the changes to the webwork-playground environment so that you can test in a live environment if that's easier.)

boonebgorges added a commit that referenced this issue May 4, 2018
@boonebgorges
Some upload/alt tag fixes.
bf13d5c 
* Ensure that non-admins can upload and edit images.
* Don't double-add alt tag notice.

See #107, #118.
boonebgorges added a commit that referenced this issue May 4, 2018
@boonebgorges
Sidebar should be reinitialized on every alt check.
228c62d 
Otherwise it breaks during the upload process.

See #107, #118.
@bree-z
Copy link
Collaborator

bree-z commented May 25, 2018

Functionality is working well. Does this still need design input from @jennaspevack ? Thanks!

@boonebgorges
Copy link
Collaborator Author

It would be nice to get thoughts from @jennaspevack, even if it's just "that looks good" - the main reason being that we may want to adapt this change for the OpenLab more generally at some point. (The main design points are: 1. the wording, styling, placement of the 'You must supply...' message, and 2. the red outline on the 'Alt Text' input field.)

"Looks good for OL-WW, may need more revision for OL" is a perfectly good answer for now!

@jennaspevack
Copy link
Collaborator

Looks great! Sorry for the delay.

@boonebgorges boonebgorges mentioned this issue Jun 1, 2018
Closed
@boonebgorges
Copy link
Collaborator Author

Great, thanks! There may still be some weirdness on mobile, but we are addressing in #122, so I think this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boonebgorges boonebgorges

@jennaspevack jennaspevack

Labels
needs-design
Projects
None yet
Milestone
Fall 2018
Development

No branches or pull requests
3 participants
@boonebgorges @bree-z @jennaspevack