Sidebar should be reinitialized on every alt check.

Otherwise it breaks during the upload process. See #107, #118.
openlab-at-city-tech · May 4, 2018 · 228c62d · 228c62d
1 parent bf13d5c
commit 228c62d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/build/index.js b/build/index.js
@@ -40022,9 +40022,9 @@ const mapDispatchToProps = (dispatch, ownProps) => {
 
 			frame.views.ready = function () {
 				const toolbarView = frame.views.get('.media-frame-toolbar')[0];
-				const sidebar = frame.views.get('.media-frame-content')[0].sidebar;
 				const modal = frame.modal;
 				const library = frame.library;
+				let sidebar;
 
 				toolbarView.controller.on('select', function () {
 					var selected = frame.state().get('selection');
@@ -40056,7 +40056,7 @@ const mapDispatchToProps = (dispatch, ownProps) => {
 						const warning = '<p id="alt-tag-warning" class="alt-tag-warning">You must supply alt text before inserting this image.</p>';
 						toolbarView.$el.find('#alt-tag-warning').remove();
 						toolbarView.$el.find('.media-toolbar-primary').append(warning);
-						console.log(sidebar);
+						sidebar = frame.views.get('.media-frame-content')[0].sidebar;
 						sidebar.$el.find('label.setting[data-setting="alt"]').addClass('has-error');
 					}
 				});

diff --git a/build/index.js.map b/build/index.js.map
diff --git a/src/containers/UploaderContainer.js b/src/containers/UploaderContainer.js
@@ -54,9 +54,9 @@ const mapDispatchToProps = (dispatch, ownProps) => {
 
 			frame.views.ready = function() {
 				const toolbarView = frame.views.get('.media-frame-toolbar')[0]
-				const sidebar = frame.views.get('.media-frame-content')[0].sidebar
 				const modal = frame.modal
 				const library = frame.library
+				let sidebar
 
 				toolbarView.controller.on('select',function() {
 					var selected = frame.state().get('selection')
@@ -88,7 +88,7 @@ const mapDispatchToProps = (dispatch, ownProps) => {
 						const warning = '<p id="alt-tag-warning" class="alt-tag-warning">You must supply alt text before inserting this image.</p>'
 						toolbarView.$el.find('#alt-tag-warning').remove()
 						toolbarView.$el.find('.media-toolbar-primary').append(warning)
-						console.log(sidebar);
+						sidebar = frame.views.get('.media-frame-content')[0].sidebar
 						sidebar.$el.find('label.setting[data-setting="alt"]').addClass('has-error')
 					}
 				})