Update the ptemcee dependency #137
Conversation
The original ptemcee repo is not maintained. I changed the dependency to be my fork of the ptemcee repo. I have a minimal fix in my fork compared to the original repo, but it fixes some incompatibility, especially with newer numpy.
|
@mjwen Just created a PR for the update for ptemcee dependency. |
|
@yonatank93 The CI test is failing. I took a look and seems there might be some specific syntax to add a git repo to Can you try installing it locally and see whether we still have the error as in the CI test, and if yes, we need to fix it. |
We use Yonatan's fork of ptemcee as dependency, but that version of package is not registered in pypi. So, we need to specify the link to the repo (and the specific branch). But, apparently there is a specific way how we can list such repo. So, this commit fixes this problem.
|
@mjwen I was able to reproduce the issue. I think the problem is how I listed ptemcee in |
|
@yonatank93 Yeah, it worked. Thanks! One more request: can you delete the comments above |
Since now we use Yonatan's fork of ptemcee, we don't need to limit using numpy<1.2.0. The comment in this setup.py about this issue is not necessary anymore.
|
@mwen I just did it. Let me know if there are any changes that you want me to make. I also haven't worked on the uq test, as you suggested. |
|
Let's wait until most of Amit's stuff gets merged and then we can think once more about how to adapt the UQ tests. |
The original ptemcee repo is not maintained. I changed the dependency to be my fork of the ptemcee repo. I have a minimal fix in my fork compared to the original repo, but it fixes some incompatibility, especially with newer numpy.