Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "ptemcee" and "emcee" #127

Closed
mjwen opened this issue Jul 30, 2023 · 5 comments
Closed

Update "ptemcee" and "emcee" #127

mjwen opened this issue Jul 30, 2023 · 5 comments

Comments

@mjwen
Copy link
Collaborator

mjwen commented Jul 30, 2023

Hi @yonatank93, as discussed previously offline, we might need to udpdate "ptemcee" and "emcee". They are using very old numpy APIs that are not supported anymore. To move forward, e.g. using python3.10, we need to get these resolved. See a TODO in setup.py.

I think since the package (I cannot remember which one of ptemcee" and "emcee") seems dead, I guess the easiest approach is to fork and fix it, then we make the forked on as the dependency. What do you think?

If you can find other well-maintained packages that provide the same functionality, we can switch to them as well.

@yonatank93
Copy link
Contributor

emcee is still well maintained, but ptemcee is not (the owner says that in the repo). I agree that maybe the best option is to fork it. I have my own fork that works, but I think we should fork it in openkim. I don't think I have access to do that, though.

@mjwen
Copy link
Collaborator Author

mjwen commented Jul 30, 2023

It would be fine to use the one in your github account. If it is updated, we can switch to using yours as the dependency.

@yonatank93
Copy link
Contributor

What I have in my github account is a minimum update on ptemcee. Basically I just fix the problem with using np.float. Here is the link to my fork: https://github.com/yonatank93/ptemcee/tree/enhance_v1.0.0

@mjwen
Copy link
Collaborator Author

mjwen commented Nov 14, 2023

@yonatank93 can you please make a PR to make your version of ptemcee a dependency instead of the original one? Then we can be able use new version of python. Thanks !

I believe you will need to modify setup.py

@mjwen
Copy link
Collaborator Author

mjwen commented Dec 14, 2023

Fixed in #137

@mjwen mjwen closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants