-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: heatwaveR: A central algorithm for the detection of heatwaves and cold-spells #821
Comments
Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @khaors it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
@khaors The review checklist is available here. Let me know if you have questions. |
@leeper In the Installation Instructions, the list of dependencies should be clearly stated. Is this referring to the README file in addition to the DESCRIPTION file? |
@khaors DESCRIPTION file is fine, unless there are non-CRAN, non-R, or otherwise atypical dependencies. |
@leeper I have finished the review. Sorry for the delay. Checking the vignettes took a while but the results are ok. I opened an issue in the heatwaveR repository with the my comments ( you can check this under the tag JOSS review). |
@khaors Excellent. Thanks for your careful review! @robwschlegel Please address the issues raised at: robwschlegel/heatwaveR#7 and let me know when you're ready for me to take another look. |
Hello,
Thank you very much for reviewing the package.
I've read over the comments and am happy to make the changes. I'm
particularly glad that it was recommended to cut down the length of the
README and move that information to separate vignettes.
I've just returned now from a conference and have some work to catch up on
but will make the corrections as soon as I can. Hopefully within a week.
All the best,
-Robert
…On Thu, 19 Jul 2018, 12:42 Thomas J. Leeper ***@***.***> wrote:
@khaors <https://github.com/khaors> Excellent. Thanks for your careful
review!
@robwschlegel <https://github.com/robwschlegel> Please address the issues
raised at: robwschlegel/heatwaveR#7
<robwschlegel/heatwaveR#7> and let me know when
you're ready for me to take another look.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#821 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHNY5xHZUvTepZaXik9DtbMkQaBj53d7ks5uIGKpgaJpZM4VMaRL>
.
|
I've addressed the issues at robwschlegel/heatwaveR#7 |
Great, thank you @robwschlegel. @khaors Can you take a look and see if there's anything else that should be addressed? |
@leeper I checked and the suggestions have been addressed and the heatwaveR package has been modified in accordance. |
Great. Thanks! |
@robwschlegel The review process is now complete. To finalize your submission and accept your paper in JOSS, we need you to deposit a copy of your software repository (including any revisions made during the JOSS review process) with a data-archiving service. To do so:
Let me know if you have any questions about the process. |
@leeper |
@leeper |
@whedon set 10.5281/zenodo.1324309 as archive |
OK. 10.5281/zenodo.1324309 is the archive. |
@arfon over to you |
@khaors - many thanks for your review here and to @leeper for editing this submission ✨ @robwschlegel - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00821 ⚡ 🚀 💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Woohoo! |
Submitting author: @robwschlegel (Robert Schlegel)
Repository: https://github.com/robwschlegel/heatwaveR
Version: 0.2.7
Editor: @leeper
Reviewer: @khaors
Archive: 10.5281/zenodo.1324309
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@khaors, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @leeper know.
Review checklist for @khaors
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: