Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: heatwaveR: A central algorithm for the detection of heatwaves and cold-spells #768

Closed
whedon opened this issue Jun 10, 2018 · 28 comments
Assignees

Comments

@whedon
Copy link

whedon commented Jun 10, 2018

Submitting author: @robwschlegel (Robert Schlegel)
Repository: https://github.com/robwschlegel/heatwaveR
Version: 0.2.7
Editor: @leeper
Reviewers: @khaors

Author instructions

Thanks for submitting your paper to JOSS @robwschlegel. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@robwschlegel if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jun 10, 2018

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

@whedon
Copy link
Author

whedon commented Jun 10, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jun 10, 2018

@leeper
Copy link
Member

leeper commented Jun 10, 2018

@whedon assign @leeper as editor

@whedon
Copy link
Author

whedon commented Jun 10, 2018

OK, the editor is @leeper

@leeper
Copy link
Member

leeper commented Jun 10, 2018

@dhhagan Would you be willing to review this for JOSS?

@leeper
Copy link
Member

leeper commented Jun 18, 2018

@geanders Would you be willing to review this for JOSS?

@robwschlegel
Copy link

robwschlegel commented Jun 18, 2018 via email

@leeper
Copy link
Member

leeper commented Jun 18, 2018

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 18, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jun 18, 2018

@robwschlegel
Copy link

robwschlegel commented Jun 18, 2018 via email

@leeper
Copy link
Member

leeper commented Jun 25, 2018

@dhhagan @geanders Just another quick ping - would either of you be interested in reviewing this for JOSS?

@dhhagan
Copy link

dhhagan commented Jun 25, 2018

Hey @leeper Sorry for the delay - I am a bit busy at the moment, but could get to it in ~2 weeks?

@leeper
Copy link
Member

leeper commented Jun 25, 2018

@dhhagan Ok, thanks. I'll see if I can find someone else before then but might come back to you.

@leeper
Copy link
Member

leeper commented Jun 25, 2018

@adamhsparks Would you be willing to review this package for JOSS?

@geanders
Copy link

I'm in the same boat. It looks like a really interesting package, but it would take me a couple of weeks to get to it.

@leeper
Copy link
Member

leeper commented Jun 25, 2018

@geanders No problem. May come back to you. Thanks!

@adamhsparks
Copy link

adamhsparks commented Jun 25, 2018 via email

@leeper
Copy link
Member

leeper commented Jun 26, 2018

@adamhsparks Don't worry about it!

@leeper
Copy link
Member

leeper commented Jul 11, 2018

@khaors Would you be willing to review this software for JOSS?

@khaors
Copy link

khaors commented Jul 11, 2018

@leeper, sure, I can help. What is the procedure?

@leeper
Copy link
Member

leeper commented Jul 11, 2018

@khaors That's great! Thanks so much. In brief, the procedure is that I will open a new Github issue here with a checklist which will ask you to review a number of aspects of the software for completeness and quality. If anything is missing or you would like to see changes, you can write a text-form review or open issues on the source repository. When your review is finished, I'll take a look and confirm any needed changes with the author. I may ask you to take another quick look after those changes are made. And that's it. We also have a much more detailed set of guidelines and procedures available for you. If that all sounds okay, I'll open up the review for you.

@khaors
Copy link

khaors commented Jul 11, 2018

@leeper Yes, that sounds great. Please open up the review to start the process.

@leeper
Copy link
Member

leeper commented Jul 12, 2018

@whedon assign @khaors as reviewer

@whedon
Copy link
Author

whedon commented Jul 12, 2018

OK, the reviewer is @khaors

@leeper
Copy link
Member

leeper commented Jul 12, 2018

@whedon start review

@whedon
Copy link
Author

whedon commented Jul 12, 2018

OK, I've started the review over in #821. Feel free to close this issue now!

@leeper leeper closed this as completed Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants