[REVIEW]: startinpy: A Python library for modelling and processing 2.5D triangulated terrains #7123

editorialbot · 2024-08-20T15:06:12Z

Submitting author: @hugoledoux (Hugo Ledoux)
Repository: https://github.com/hugoledoux/startinpy
Branch with paper.md (empty if default branch):
Version: 0.12.0
Editor: @mikemahoney218
Reviewers: @weiji14, @kylemann16, @gadomski
Archive: 10.5281/zenodo.14001126

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/eae73ba0c3b646cc562a010e58c5b7a5"><img src="https://joss.theoj.org/papers/eae73ba0c3b646cc562a010e58c5b7a5/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/eae73ba0c3b646cc562a010e58c5b7a5/status.svg)](https://joss.theoj.org/papers/eae73ba0c3b646cc562a010e58c5b7a5)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@weiji14 & @kylemann16, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mikemahoney218 know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @weiji14

📝 Checklist for @gadomski

📝 Checklist for @kylemann16

The text was updated successfully, but these errors were encountered:

editorialbot · 2024-08-20T15:06:16Z

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot · 2024-08-20T15:06:34Z

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (1703.6 files/s, 151548.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          26            182             93           1145
Rust                             1             62            418            901
Markdown                        13            265              0            774
YAML                             3             22              1            190
TeX                              1             27              0            117
TOML                             3             10              2             41
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            48            572            521           3177
-------------------------------------------------------------------------------

Commit count by author:

   402	Hugo Ledoux
    11	Ewout ter Hoeven
     1	Maarten Pronk

editorialbot · 2024-08-20T15:06:39Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1007/BFb0014497 is OK
- 10.1038/s41597-024-03091-9 is OK
- 10.1016/S0098-3004(03)00017-7 is OK
- 10.1142/S0218195905001580 is OK
- 10.1145/237218.237337 is OK
- 10.1145/235815.235821 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Generation of a triangular grid with applications ...
- No DOI given, and none found for title: Spatial Height prediction of ICESat-2 data using r...
- No DOI given, and none found for title: Canopy gap fraction estimation from ICESat-2 ATL08...
- No DOI given, and none found for title: A brief description of natural neighbour interpola...
- No DOI given, and none found for title: The non-Sibsonian interpolation: A new method of i...
- No DOI given, and none found for title: Fast polygonal approximation of terrain and height...

❌ MISSING DOIs

- 10.1016/j.isprsjprs.2008.09.007 may be a valid DOI for title: Full-waveform topographic lidar: State-of-the-art

❌ INVALID DOIs

- http://dx.doi.org/10.1142/8685 is INVALID because of 'https://doi.org/' prefix

editorialbot · 2024-08-20T15:06:42Z

Paper file info:

📄 Wordcount for paper.md is 930

✅ The paper includes a Statement of need section

editorialbot · 2024-08-20T15:06:44Z

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot · 2024-08-20T15:07:37Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

mikemahoney218 · 2024-08-20T15:07:47Z

👋🏼 @hugoledoux @weiji14 @kylemann16 @gadomski this is the review thread for the paper. Just about of our communications will happen here from now on 😄

As a reviewer, the first step is to create a checklist for your review by entering

@editorialbot generate my checklist

as the top of a new comment in this thread.

These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention openjournals/joss-reviews#7123 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.

We aim for reviews to be completed within about 4 weeks. Please let me know if you require some more time.

Please feel free to ping me (@mikemahoney218) if you have any questions/concerns. Thank you so much for reviewing for JOSS!

mikemahoney218 · 2024-08-20T20:26:41Z

@editorialbot add @gadomski as reviewer

👋 Pete, this is the review thread for startinpy. Hopefully my notes above make sense -- please feel free to reach out if you have any questions or anything comes up during your review. Thank you so much for reviewing for JOSS!

editorialbot · 2024-08-20T20:26:43Z

@gadomski added to the reviewers list!

gadomski · 2024-08-21T13:44:38Z

Review checklist for @gadomski

Conflict of interest

I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

I confirm that I read and will adhere to the JOSS code of conduct.

General checks

Repository: Is the source code for this software available at the https://github.com/hugoledoux/startinpy?
License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
Contribution and authorship: Has the submitting author (@hugoledoux) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

Installation: Does installation proceed as outlined in the documentation?
Functionality: Have the functional claims of the software been confirmed?
Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
State of the field: Do the authors describe how this software compares to other commonly-used packages?
Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

These suggestions came out of an initial review of the JOSS paper as a part of openjournals/joss-reviews#7123. These are merely suggestions, and by no means are required to be taken up during the review process. I just thought I'd do a quick-once over while reading through.

hugoledoux · 2024-08-22T12:37:37Z

btw @gadomski has already started and made 2 PR directly in the branch master of startinpy, which is fine.

My plan is to work directly on master (code+paper) during this review and at the end bump the version (0.12 or 1.0, depending on what you guys suggest also).

hugoledoux · 2024-08-22T12:50:38Z

@editorialbot generate pdf

editorialbot · 2024-08-22T12:51:55Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

mikemahoney218 · 2024-09-03T23:02:11Z

Thank you so much for your speedy review, @gadomski !

@weiji14, @kylemann16 -- let me know if you have any questions or concerns with your reviews here 😄

weiji14 · 2024-09-15T21:26:09Z

Review checklist for @weiji14

Conflict of interest

I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

I confirm that I read and will adhere to the JOSS code of conduct.

General checks

Repository: Is the source code for this software available at the https://github.com/hugoledoux/startinpy?
License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
Contribution and authorship: Has the submitting author (@hugoledoux) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

5 years since initial commit on 5 May 2019, 400+ commits since then.

Over 1000 lines of code in the main file at https://github.com/hugoledoux/startinpy/blob/0.11.0/src/lib.rs, and significantly more in the actual startin (Rust) codebase.

Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

Installation: Does installation proceed as outlined in the documentation?

pip install startinpy worked for me on Linux (x86_64) with Python 3.12. I see support for Windows/macOS/Linux for Python 3.9-3.12 at https://pypi.org/project/startinpy/0.11.0/#files

Self-compiliation using maturin build --release and maturin develop works

Functionality: Have the functional claims of the software been confirmed?

"Its data structure is exposed" - Yes, confirmed that vertices and triangles are exposed. Have verified ability to find adjacent triangles via adjacent_triangles_to_triangle method

"The DT is incrementally constructed and deletion of vertices is possible" - Yes, confirmed that insertion and deletion of vertices is possible via insert and remove methods.

"The z-values are stored and xy-duplicates handled" - Yes, method for handling duplicates can be set via duplicates_handling attribute (defaults to 'First').

"Extra attributes can be stored in the DT" - There is a tutorial at https://startinpy.readthedocs.io/0.11.0/attributes.html to show how this can be done, and I was able to follow through most of the code, but encountered an issue with a missing add_attribute_map method (reported at AttributeError: 'builtins.DT' object has no attribute 'add_attribute_map' hugoledoux/startinpy#26) and fixed in hugoledoux/startinpy@55b7656

Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

"It is fast for large datasets" - I've ran some benchmarks locally on my laptop (12th Gen Intel(R) Core(TM) i5-12600HX chip, 32GB RAM, Linux), and the numbers seem comparable to the one in the comparison table at https://github.com/hugoledoux/startinpy/blob/f1d9efc8e6353fc4d5c4adfc0610d6d197604e4a/dt_comparisons/readme.md#results

library random_10k random_50k dem.tiff LAZ_2M LAZ_33M

Delaunator-pdal 0.005 0.023 32.152 1.696 32.152

startinpy 0.029 0.338 0.684 5.816 65.770

triangle 0.006 0.031 0.232 1.548 28.968

Documentation

A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.

After a clean install via pip install startinpy, I tried running the example at https://startinpy.readthedocs.io/0.11.0/howitworks.html and got an error about NumPy not being installed, reported at List numpy as required dependency? hugoledoux/startinpy#25 and fixed in hugoledoux/startinpy@339ab8e

Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).

Yes, many examples on how to read in and export data are listed under https://startinpy.readthedocs.io/0.11.0/examples.html

Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?

Yes, API docs are listed under https://startinpy.readthedocs.io/0.11.0/api.html, and the methods/attributes for the startinpy.DT class should be complete since docs are using Sphinx autoclass at https://github.com/hugoledoux/startinpy/blob/f1d9efc8e6353fc4d5c4adfc0610d6d197604e4a/docs/api.md?plain=1#L32-L35

Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?

CI builds to compile the Rust components on Linux/macOS/Windows are setup at https://github.com/hugoledoux/startinpy/blob/0.11.0/.github/workflows/build.yml

Python test files are available under https://github.com/hugoledoux/startinpy/tree/0.11.0/tests, and instructions for manual testing were added in Add notes about running the test suite hugoledoux/startinpy#21. Do not see any automated CI services for running pytest yet.

Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Yes. 1) Development installation instructions are available at https://startinpy.readthedocs.io/0.11.0/installation.html#development-to-debug-the-code. 2&3) Users looking at the docs at https://startinpy.readthedocs.io/0.11.0/issues.html are pointed to the GitHub issue page for issues/bugs/questions.

Software paper

Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
State of the field: Do the authors describe how this software compares to other commonly-used packages?
Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

weiji14 · 2024-09-15T23:20:25Z

Just quickly mentioning that I've done an initial round of reviewing the paper and repository code (#7123 (comment)), and have been pleased so far with the quality of the software and writing! So far, I have only two minor suggestions (reported at hugoledoux/startinpy#25 and hugoledoux/startinpy#26) for @hugoledoux to resolve, that can hopefully be addressed with a couple of small PRs/commits.

I do have two remaining items on my checklist in terms of verifying the Performance benchmarks and a more thorough Reproducibility check that will both take more time, but will try to get those done this or next week.

mikemahoney218 · 2024-09-16T11:25:25Z

Thank you, @weiji14 !

mikemahoney218 · 2024-11-04T13:51:08Z

@editorialbot set 0.12.0 as version

editorialbot · 2024-11-04T13:51:11Z

Done! version is now 0.12.0

mikemahoney218 · 2024-11-04T13:51:25Z

@editorialbot set 10.5281/zenodo.14001126 as archive

editorialbot · 2024-11-04T13:51:28Z

Done! archive is now 10.5281/zenodo.14001126

hugoledoux · 2024-11-11T09:56:33Z

@mikemahoney218 is there anything I should do to finalise the acceptance?

mikemahoney218 · 2024-11-11T13:33:37Z

Sorry @hugoledoux , I still haven't finished my checklist -- wound up being out most of last week due to a death in the family. Will get to this today.

mikemahoney218 · 2024-11-11T13:36:54Z

@editorialbot recommend-accept

Think I can actually go ahead with this now -- paper looks great!

editorialbot · 2024-11-11T13:36:56Z

Attempting dry run of processing paper acceptance...

editorialbot · 2024-11-11T13:37:26Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1142/8685 is OK
- 10.1016/j.isprsjprs.2008.09.007 is OK
- 10.1016/0012-365X(72)90093-3 is OK
- 10.1007/BFb0014497 is OK
- 10.1038/s41597-024-03091-9 is OK
- 10.1016/S0098-3004(03)00017-7 is OK
- 10.1142/S0218195905001580 is OK
- 10.1145/237218.237337 is OK
- 10.1145/235815.235821 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Spatial Height prediction of ICESat-2 data using r...
- No DOI given, and none found for title: Canopy gap fraction estimation from ICESat-2 ATL08...
- No DOI given, and none found for title: A brief description of natural neighbour interpola...
- No DOI given, and none found for title: The non-Sibsonian interpolation: A new method of i...
- No DOI given, and none found for title: Fast polygonal approximation of terrain and height...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

editorialbot · 2024-11-11T13:38:36Z

👋 @openjournals/ese-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6110, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

mikemahoney218 · 2024-11-11T13:40:03Z

🎉 With everything looking good on my end, it's time for me to hand this back to the EiC for last steps. Thanks @hugoledoux for the submission, and thank you so much to @weiji14, @kylemann16, and @gadomski for reviewing!

kthyng · 2024-11-11T21:17:43Z

Hi! I'll take over now as Track Associate Editor in Chief to do some final submission editing checks. After these checks are complete, I will publish your submission!

Are checklists all checked off?
Check that version was updated and make sure the version from JOSS matches github and Zenodo.
Check that software archive exists, has been input to JOSS, and title and author list match JOSS paper (or purposefully do not).
Check paper.

kthyng · 2024-11-11T21:23:19Z

@hugoledoux
Please check the capitalization in your references. You can preserve capitalization by placing {} around characters/words in your .bib file. ("delaunay" is not capitalized, but please check other words too)

hugoledoux · 2024-11-12T07:02:54Z

done ✅

kthyng · 2024-11-12T15:58:54Z

@editorialbot generate pdf

editorialbot · 2024-11-12T16:00:24Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

kthyng · 2024-11-12T16:13:24Z

Excellent @hugoledoux! Looks good to go!

kthyng · 2024-11-12T16:13:30Z

@editorialbot accept

editorialbot · 2024-11-12T16:13:33Z

Doing it live! Attempting automated processing of paper acceptance...

editorialbot · 2024-11-12T16:20:45Z

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- family-names: Ledoux
  given-names: Hugo
  orcid: "https://orcid.org/0000-0002-1251-8654"
doi: 10.5281/zenodo.14001126
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - family-names: Ledoux
    given-names: Hugo
    orcid: "https://orcid.org/0000-0002-1251-8654"
  date-published: 2024-11-12
  doi: 10.21105/joss.07123
  issn: 2475-9066
  issue: 103
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 7123
  title: "startinpy: A Python library for modelling and processing 2.5D
    triangulated terrains"
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.07123"
  volume: 9
title: "startinpy: A Python library for modelling and processing 2.5D
  triangulated terrains"

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot · 2024-11-12T16:20:50Z

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot · 2024-11-12T16:20:51Z

🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋

editorialbot · 2024-11-12T16:20:51Z

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.07123 joss-papers#6121
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.07123
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

hugoledoux · 2024-11-12T16:40:33Z

thanks everyone, the package is better because of you and the JOSS process

kthyng · 2024-11-12T17:09:56Z

Congratulations on your new publication @hugoledoux! Many thanks to editor @mikemahoney218 and to reviewers @weiji14, @kylemann16, and @gadomski for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts.

editorialbot · 2024-11-12T17:10:00Z

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following

code snippets

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.07123/status.svg)](https://doi.org/10.21105/joss.07123)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.07123">
  <img src="https://joss.theoj.org/papers/10.21105/joss.07123/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.07123/status.svg
   :target: https://doi.org/10.21105/joss.07123

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

editorialbot added Python review Rust TeX Track: 6 (ESE) Earth Sciences and Ecology labels Aug 20, 2024

editorialbot assigned mikemahoney218 Aug 20, 2024

editorialbot mentioned this issue Aug 20, 2024

[PRE REVIEW]: startinpy: A Python library for modelling and processing 2.5D triangulated terrains #7001

Closed

This was referenced Aug 21, 2024

Some minor grammar, punctuation, and wording suggestions hugoledoux/startinpy#20

Merged

Add notes about running the test suite hugoledoux/startinpy#21

Merged

gadomski mentioned this issue Aug 22, 2024

Add PDAL to comparison matrix hugoledoux/startinpy#23

Closed

This was referenced Sep 15, 2024

List numpy as required dependency? hugoledoux/startinpy#25

Closed

AttributeError: 'builtins.DT' object has no attribute 'add_attribute_map' hugoledoux/startinpy#26

Closed

editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Nov 11, 2024

editorialbot added accepted published Papers published in JOSS labels Nov 12, 2024

kthyng closed this as completed Nov 12, 2024

[REVIEW]: startinpy: A Python library for modelling and processing 2.5D triangulated terrains #7123

[REVIEW]: startinpy: A Python library for modelling and processing 2.5D triangulated terrains #7123

Comments

editorialbot commented Aug 20, 2024 • edited Loading

Status

Reviewer instructions & questions

Checklists

editorialbot commented Aug 20, 2024

editorialbot commented Aug 20, 2024

editorialbot commented Aug 20, 2024

editorialbot commented Aug 20, 2024

editorialbot commented Aug 20, 2024

editorialbot commented Aug 20, 2024

mikemahoney218 commented Aug 20, 2024 • edited Loading

mikemahoney218 commented Aug 20, 2024

editorialbot commented Aug 20, 2024

gadomski commented Aug 21, 2024 • edited Loading

Review checklist for @gadomski

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

hugoledoux commented Aug 22, 2024 • edited Loading

hugoledoux commented Aug 22, 2024 • edited Loading

editorialbot commented Aug 22, 2024

mikemahoney218 commented Sep 3, 2024

weiji14 commented Sep 15, 2024 • edited Loading

Review checklist for @weiji14

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

weiji14 commented Sep 15, 2024

mikemahoney218 commented Sep 16, 2024

mikemahoney218 commented Nov 4, 2024

editorialbot commented Nov 4, 2024

mikemahoney218 commented Nov 4, 2024

editorialbot commented Nov 4, 2024

hugoledoux commented Nov 11, 2024

mikemahoney218 commented Nov 11, 2024

mikemahoney218 commented Nov 11, 2024

editorialbot commented Nov 11, 2024

editorialbot commented Nov 11, 2024

editorialbot commented Nov 11, 2024

mikemahoney218 commented Nov 11, 2024

kthyng commented Nov 11, 2024 • edited Loading

kthyng commented Nov 11, 2024

hugoledoux commented Nov 12, 2024

kthyng commented Nov 12, 2024

editorialbot commented Nov 12, 2024

kthyng commented Nov 12, 2024

kthyng commented Nov 12, 2024

editorialbot commented Nov 12, 2024

editorialbot commented Nov 12, 2024

editorialbot commented Nov 12, 2024

editorialbot commented Nov 12, 2024

editorialbot commented Nov 12, 2024

hugoledoux commented Nov 12, 2024

kthyng commented Nov 12, 2024

editorialbot commented Nov 12, 2024

editorialbot commented Aug 20, 2024 •

edited

Loading

mikemahoney218 commented Aug 20, 2024 •

edited

Loading

gadomski commented Aug 21, 2024 •

edited

Loading

hugoledoux commented Aug 22, 2024 •

edited

Loading

hugoledoux commented Aug 22, 2024 •

edited

Loading

weiji14 commented Sep 15, 2024 •

edited

Loading

kthyng commented Nov 11, 2024 •

edited

Loading