-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: startinpy: A Python library for modelling and processing 2.5D triangulated terrains #7001
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
@hugoledoux Can you add your affiliation to the paper? |
@editorialbot generate pdf |
|
@editorialbot generate pdf |
Five most similar historical JOSS papers: SeismicMesh: Triangular meshing for seismology TessPy: a python package for geographical tessellation Efficient Polyhedral Gravity Modeling in Modern C++ and Python Ripser.py: A Lean Persistent Homology Library for Python Nanomesh: A Python workflow tool for generating meshes from image data |
@kthyng okay fixed it. I was puzzled because the affiliation was there and I had successfully compiled it with the github action... but I wasn't using the latest v4 it seems, and things have changed. Mystery solved. |
Hi @hugoledoux and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:
In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them. |
5 suggested reviewers that seems to be a good fit, from the JOSS database: |
Hi @hugoledoux! Two things:
|
@editorialbot generate pdf |
Five most similar historical JOSS papers: 3dfier: automatic reconstruction of 3D city models DTCC Builder: A mesh generator for automatic, efficient, and robust mesh generation for large-scale city modeling and simulation lidar: A Python package for delineating nested surface depressions from digital elevation data Ripser.py: A Lean Persistent Homology Library for Python fractopo: A Python package for fracture network analysis |
@kthyng I have cut the paper in half, and moved the material to the docs online: https://startinpy.readthedocs.io/latest/ |
@editorialbot generate pdf |
Five most similar historical JOSS papers: 3dfier: automatic reconstruction of 3D city models DTCC Builder: A mesh generator for automatic, efficient, and robust mesh generation for large-scale city modeling and simulation lidar: A Python package for delineating nested surface depressions from digital elevation data Ripser.py: A Lean Persistent Homology Library for Python fractopo: A Python package for fracture network analysis |
Ok thanks @hugoledoux. I'll add this to the waitlist while we wait for a relevant editor to have capacity. Thanks for your patience. |
@mikemahoney218 Can you edit this submission? |
@editorialbot invite @mikemahoney218 as editor |
Invitation to edit this submission sent! |
@editorialbot assign me as editor |
Assigned! @mikemahoney218 is now the editor |
Happy to take this one on! It's going to take me a little bit to start requesting reviews -- apologies, transitioning from a conference to a new position -- but I'll follow up as I hear back. |
@weiji14 -- would you be willing to review a submission for the Journal of Open Source Software? At JOSS, we carry out our checklist-driven reviews here in GitHub issues, encourage author-reviewer-editor conversations, and reviews involve downloading and installing the software, and inspecting the repository and submitted paper. See https://joss.readthedocs.io/en/latest/review_criteria.html for more about our review process. Editors and reviewers post comments on the Review issue, and authors respond to the comments and improve their submission until acceptance (or withdrawal, if they feel unable to satisfy the review). We aim for the initial review to be completed within 4 weeks (which would bring us to September 9th), though we can of course be flexible as needed. Would you be willing to review this submission for JOSS? If not, can you recommend any other potential reviewers? |
Oo nice, a maturin project, and working with LiDAR data! Yes I would be more than happy to review this. I will note that I'll be travelling for two weeks until 1st September, so there might be delays in finding time to review, but I'll let you know if I need more time beyond the 9th September date. |
@editorialbot assign @weiji14 as reviewer Fantastic, thank you so much! I'll formally start the review (and follow up with more details) when I get a second reviewer onboard 😄 |
I'm sorry human, I don't understand that. You can see what commands I support by typing:
|
@editorialbot add @weiji14 as reviewer (apologies, I always mess that one up...) |
@weiji14 added to the reviewers list! |
Just for awareness here, I'm still searching for a second reviewer -- @hugoledoux , if you had additional ideas for who might be a good fit, that would be useful; otherwise I'll keep searching. |
Given this PR, maybe @DanielVandH can review? |
or I think that anyone using terrains and Python is a suitable candidate here, so besides those I listed above I can think of LSDtopotools or martibosch |
@editorialbot add @kylemann16 as reviewer |
@kylemann16 added to the reviewers list! |
@editorialbot start review |
OK, I've started the review over in #7123. |
Submitting author: @hugoledoux (Hugo Ledoux)
Repository: https://github.com/hugoledoux/startinpy
Branch with paper.md (empty if default branch):
Version: 0.11.0
Editor: @mikemahoney218
Reviewers: @weiji14, @kylemann16
Managing EiC: Kristen Thyng
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @hugoledoux. Currently, there isn't a JOSS editor assigned to your paper.
@hugoledoux if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: