[REVIEW]: dust_extinction: Interstellar Dust Extinction Models #7023
Comments
editorialbot
added
Python
review
TeX
Track: 1 (AASS)
|
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type: For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type: |
|
|
Software report: Commit count by author: |
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
|
License info: ✅ License found: |
|
@TheSkyentist and @keflavich, thank you both for agreeing to review this submission! Please refer to the instructions on the top of this tread on how to get started with the review. Don't hesitate to reach out if you have any questions, either here or via e-mail. We are shooting for the first round of review to be competed in about a month (considering summer and all) so ~ August 20th or so. |
Review checklist for @keflavichConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
|
@editorialbot generate pdf |
|
I have updated the paper based on @keflavich PR and suggestions. |
Review checklist for @TheSkyentistConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
|
@editorialbot generate pdf |
|
I have updated the paper and the repository based on @TheSkyentist suggestions. |
|
The purpose, documentation, and examples for the code are all well described in the JOSS submission. The code is installable, flexible, and useful for current and future astronomical analysis. With the additional changes made by @karllark I would recommend this submission be accepted. |
|
I would like to thank @TheSkyentist and @keflavich for their thoughtful reviews. Much appreciated! |
|
@keflavich, can you please review the changes and let me know if you accept the submission (or have further comments)? |
|
@editorialbot generate pdf |
|
@editorialbot check references |
|
|
Done! archive is now 10.5281/zenodo.13333814 |
|
@editorialbot set v1.5 as version |
|
Done! version is now v1.5 |
|
@editorialbot generate pdf |
|
@editorialbot check references |
|
|
@editorialbot recommend-accept |
|
|
IDREFS attribute rid references an unknown ID "figU003AgrainU0029" |
|
@keflavich and @TheSkyentist, thank you both for the expedient and detailed reviews! |
|
PR (karllark/dust_extinction#235) to fix type merged. Thanks @ivastar! |
|
@editorialbot recommend-accept |
|
|
|
👋 @openjournals/aass-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5792, then you can now move forward with accepting the submission by compiling again with the command |
editorialbot
added
the
recommend-accept
|
🎉 success! Thank you for submitting to JOSS @karllark! Pleasure working with you on this. The editor in chief has to push the final button for publication, which he will probably do in the next week or so. But our work here is done. |
|
Most excellent! Thanks to all that worked on this submission! Excited to have this paper appear and to have an awesome reference for this package. |
|
@editorialbot accept |
|
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
|
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
|
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
|
Many thanks to @TheSkyentist and @keflavich for reviewing and to @ivastar for editing! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!! @karllark — Your paper is now accepted and published in JOSS! ⚡🚀💥 |
|
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets: This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @karllark (Karl Gordon)
Repository: https://github.com/karllark/dust_extinction
Branch with paper.md (empty if default branch):
Version: v1.5
Editor: @ivastar
Reviewers: @TheSkyentist, @keflavich
Archive: 10.5281/zenodo.13333814
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@TheSkyentist & @keflavich, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @ivastar know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @keflavich
📝 Checklist for @TheSkyentist
The text was updated successfully, but these errors were encountered: