-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: DataInterpolations.jl: Fast Interpolations of 1D data #6917
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
@carstenbauer, @dawbarton, @sathvikbhagavan – This is the review thread for the paper. All of our communications will happen here from now on. Please read the "Reviewer instructions & questions" in the first comment above. Please create your checklist typing:
As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. |
Review checklist for @dawbartonConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@carstenbauer, @dawbarton - A gentle reminder to start the review process. |
Review checklist for @carstenbauerConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
I've made my pass over my checklist, the package source code/documentation, and the short paper. Here are my comments and questions. All of them should be straightforward to integrate and answer, respectively.
Bonus:
Provided that these points are taken into account by the authors, I am happy to recommend the paper for publication. |
@dawbarton – I see you've started your review (thanks 😄), do you think you might be able to complete it soon? |
@editorialbot generate pdf |
Thanks @carstenbauer for the review! I have addressed 1, 2, 3 points in the paper. I have addressed 4 - added statement of need in the documentation. I have also added a tutorial for using DataInterpolations with Symbolics and referenced that in the paper. |
Sorry for the delay, I’ll try to get it done this week but it might slip into early next week. |
Sorry for the delay with this. Overall, it looks good to me, particularly with carstenbauer's comments. A few minor comments on the paper:
As a side note, it might be worth a mention somewhere in the documentation that vectors-of-vectors can be used for the input to get multiple outputs from DataInterpolations. (This wasn't obvious to me and it doesn't accept a matrix as an input.) |
@editorialbot generate pdf |
Looks good to me. |
Thanks! |
No, I think the authors have done a good job of integrating my comments. Happy to suggest the paper for publication. |
@arfon, is there anything else here to be done for the paper? Both the reviewers are satisfied with it. |
@sathvikbhagavan – apologies for the delay, I was OoO on the 🏖 😎 It looks like we're very close to being done here. I will circle back here next week, but in the meantime, please give your own paper a final read to check for any potential typos etc. After that, could you make a new release of this software that includes the changes that have resulted from this review. Then, please make an archive of the software in Zenodo/figshare/other service and update this thread with the DOI of the archive? For the Zenodo/figshare archive, please make sure that:
|
Thanks! We have released the package and here is the zenodo archive: https://zenodo.org/records/13384954 |
@editorialbot set 10.5281/zenodo.13384954 as archive |
Done! archive is now 10.5281/zenodo.13384954 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5849, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
|
@editorialbot generate pdf |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@carstenbauer, @dawbarton – many thanks for your reviews here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨ @sathvikbhagavan – your paper is now accepted and published in JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @sathvikbhagavan (Sathvik Bhagavan)
Repository: https://github.com/SciML/DataInterpolations.jl
Branch with paper.md (empty if default branch):
Version: v5.1.0
Editor: @arfon
Reviewers: @carstenbauer, @dawbarton
Archive: 10.5281/zenodo.13384954
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@carstenbauer & @dawbarton, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @arfon know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @dawbarton
📝 Checklist for @carstenbauer
The text was updated successfully, but these errors were encountered: