Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix affiliation bug #77

Merged
merged 7 commits into from
Sep 16, 2024
Merged

Fix affiliation bug #77

merged 7 commits into from
Sep 16, 2024

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Sep 5, 2024

There were two issues in the prepare-affiliatons.lua script

  1. Somehow during the squash/merge process, the part where it got applied in the pdf and preprint configurations got lost. This adds them back!
  2. This PR makes it more robust for string format for affiliation lists. I'm not sure if this was actually an issue before, but I updated the example PDF to contain one of these examples just to be sure.

@arfon
Copy link
Member

arfon commented Sep 5, 2024

@tarleb – would you mind taking a look at this? Unfortunately the current build of Inara is broken for JOSS: openjournals/joss-reviews#6917 (comment)

@cthoyt
Copy link
Contributor Author

cthoyt commented Sep 5, 2024

I'm thinking it might be useful to add the make test into the CI pipeline to help us be more confident in adding changes in the future, too

see #78

@tarleb
Copy link
Collaborator

tarleb commented Sep 5, 2024

I'm thinking it might be useful to add the make test into the CI pipeline to help us be more confident in adding changes in the future, too

We do that already as part of the build pipeline.

@cthoyt
Copy link
Contributor Author

cthoyt commented Sep 5, 2024

@tarleb ah, I see this! perhaps splitting it out into its own chunk would be good, since the image builder workflow fails for PRs since I don't have credentials for dockerhub built in

@tarleb
Copy link
Collaborator

tarleb commented Sep 5, 2024

See #70

data/defaults/pdf.yaml Outdated Show resolved Hide resolved
@@ -4,7 +4,7 @@ title: >-
authors:
- name: Albert Krewinkel
email: [email protected]
affiliation: [1, 2, 4]
affiliation: "1, 2, 4"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that we're supposed to be supporting both flavors of affiliation strings, so I wanted to make sure that the example paper reflected one of each way

@xuanxu
Copy link
Member

xuanxu commented Sep 5, 2024

@arfon version 1.1.1 is deployed with a fix, build should work now 🤞

@tarleb
Copy link
Collaborator

tarleb commented Sep 16, 2024

Thank you, LGTM. There's a currently a merge conflict, this can be merged after the rebase.

@tarleb tarleb merged commit f96dcaa into openjournals:main Sep 16, 2024
0 of 2 checks passed
@cthoyt cthoyt deleted the fix-affiliation-bug branch September 16, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants