-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix affiliation bug #77
Conversation
@tarleb – would you mind taking a look at this? Unfortunately the current build of Inara is broken for JOSS: openjournals/joss-reviews#6917 (comment) |
I'm thinking it might be useful to add the see #78 |
We do that already as part of the build pipeline. |
@tarleb ah, I see this! perhaps splitting it out into its own chunk would be good, since the image builder workflow fails for PRs since I don't have credentials for dockerhub built in |
See #70 |
@@ -4,7 +4,7 @@ title: >- | |||
authors: | |||
- name: Albert Krewinkel | |||
email: [email protected] | |||
affiliation: [1, 2, 4] | |||
affiliation: "1, 2, 4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that we're supposed to be supporting both flavors of affiliation strings, so I wanted to make sure that the example paper reflected one of each way
@arfon version 1.1.1 is deployed with a fix, build should work now 🤞 |
Thank you, LGTM. There's a currently a merge conflict, this can be merged after the rebase. |
There were two issues in the
prepare-affiliatons.lua
scriptpdf
andpreprint
configurations got lost. This adds them back!