-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Contextualized: Heterogeneous Modeling Toolbox #6469
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
|
👋🏼 hi @cnellington @holl- @pescap -- this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering
as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@fabian-s) if you have any questions/concerns. |
@cnellington: while we wait for the reviews, please take a look at the missing DOIs above and see what's what. |
@editorialbot generate pdf |
@editorialbot commands |
Hello @cnellington, here are the things you can ask me to do:
|
@editorialbot check references |
|
Review checklist for @holl-Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@cnellington From the GitHub statistics, Ben Lengerich @blengerich has contributed the most to the library, at least in terms of lines of code. Why isn't he first author? Also Eric Xing is not on the list of contributors on GitHub. Did he actually contribute to the software? |
@holl- I authored the majority of our core Python packages under contextualized/, but out codebase also contains many .ipynb files for our documentation, website, and tutorials built with jupyter-book. @blengerich, in addition to making many contributions to our code codebase, also spearheaded our website/documentation efforts, and also did a large amount of standardized style formatting with Notebook inflation examples:
Style formatting inflation: Eric P. Xing is my PhD advisor, and Manolis Kellis is @blengerich's postdoc advisor. While they have not made direct contributions to the code, they have been essential in supporting and directing the software development. |
@cnellington Okay, that's fine, then. 👍 |
@cnellington I have some comments for your easy demo notebook, see this issue |
@cnellington Looking at your test setup, it seems that
|
@cnellington Your paper is missing an overview of the State of the field. In the 'Statement of need', could you add more concrete motivation for using this library and relate it to existing software solutions (incl. appropriate references)? |
@editorialbot set 10.5281/zenodo.11130703 as archive |
Done! archive is now 10.5281/zenodo.11130703 |
Post-Review Checklist for Editor and AuthorsAdditional Author Tasks After Review is Complete
Editor Tasks Prior to Acceptance
|
@editorialbot set v0.2.8 as version |
Done! version is now v0.2.8 |
@editorialbot generate pdf |
@editorialbot check references |
|
@editorialbot recommend-accept re missing DOI for "partykit": many thanks again to @holl- and @pescap for their reviews and congrats to @cnellington and coauthors! |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5319, then you can now move forward with accepting the submission by compiling again with the command |
|
👋 I am the AEiC for the Data Science, Artificial Intelligence, and Machine Learning (DSAIS) track of JOSS submissions. This is a very clean submission and made my job easy in this case! Thank you! I am pushing this through to publication. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations on your new publication @cnellington! Many thanks to @fabian-s for an excellent job editing and @holl- and @pescap for your time, hard work, and expertise in reviewing!! JOSS wouldn't be able to function nor succeed without your efforts. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @cnellington (Caleb Ellington)
Repository: https://github.com/cnellington/Contextualized
Branch with paper.md (empty if default branch): joss
Version: v0.2.8
Editor: @fabian-s
Reviewers: @holl-, @pescap
Archive: 10.5281/zenodo.11130703
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@holl- & @pescap, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @fabian-s know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @holl-
📝 Checklist for @pescap
The text was updated successfully, but these errors were encountered: