-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: activAnalyzer: An R Shiny app to analyse ActiGraph accelerometer data and to implement the use of the PROactive Physical Activity in COPD instruments #4741
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Hi @elimillera, @spitschan, @angerhang please see the instructions at the top of the review thread. Once you've generated your checklist you can use this as the basis for your review. |
Review checklist for @angerhangConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Overall, I found
@pydemull thanks a lot for making this valuable contribution to the community. I look forward to your revisions and seeing the generated report myself using some of the test files before signing off the rest of the checklist. Great job, nontheless :D |
Review checklist for @elimilleraConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Thank you very much @angerhang for your comments. Before making the required changes to the package, I have some questions to be sure of what you want.
Thanks a lot for your time and work. |
|
Dear @samhforbes @angerhang @elimillera, CRAN has requested I make some updates of the package so that it passes R-dev checking (this is in relation with a planned update of R regarding as.character.POSIXt()). I have made the update and the current CRAN version is now 1.0.5. (Thus, I will have to make a change in the JOSS paper where I gave a version number for the package; I will remove the version number for the package). |
Good question for the calculation with intersex... I have not yet found any reference regarding energy expenditure for this. I must think about it... |
@pydemull not to worry, we can set the version number both here and in the paper at the end. Thanks everyone for your discussions and input to date! |
Tested with the demo data. The report generated is super sick! Am sure many will benefit from using this software. There are still outstanding tasks regarding the sex calculation and dependency instructions. But I am happy to tick all the boxes from my checklist :D |
Thanks again for your comments! I have provided answers for the two issues you have opened. Regarding the dependency instructions, I am not sure your comment above was done before or after my answer on the dedicated GitHub issue. Please tell me if it is not enough. Best |
Thanks @angerhang for the productive comments so far. Hi @elimillera, @spitschan - while the last couple of comments from @angerhang are resolved, do let us know if there's any issues with completing the review, or let @pydemull know if there's any barriers to running anything for the review. |
Hey @pydemull, I've reviewed the package, repository, and paper. I've ran all the tests I generally run to determine package quality and they are all coming back green, they repository is well formed and has good CI and contributor information, and the paper is well written. Looks good to me! |
Thanks @elimillera for your time and work. Glad to know that all seem ok for you. @samhforbes, @angerhang, for information I have merged the dev branch with the master branch in relation to the modifications made following the @angerhang's comments. I have then taken the liberty to close the issues opened by @angerhang. Best |
@editorialbot remove @spitschan from reviewers |
@spitschan removed from the reviewers list! |
@editorialbot generate pdf |
@samhforbes please find here the DOI: 10.5281/zenodo.7384191 |
@editorialbot set v1.1.0 as version |
Done! version is now v1.1.0 |
@editorialbot set 10.5281/zenodo.7384191 as archive |
Done! Archive is now 10.5281/zenodo.7384191 |
@pydemull this looks good and the archive seems to contain everything. I am recommending accept - well done on a great paper and software package. |
@editorialbot recommend-accept |
|
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3770, then you can now move forward with accepting the submission by compiling again with the command |
|
@pydemull I am the AEiC for this track and here to help process this work for acceptance in JOSS. I have reviewed the archive and the paper and have noted the below issues that require your attention: On the archived software link https://zenodo.org/record/7384191:
On the paper:
`accelerometry` This way they are highlighted properly.
Let me know when you've addressed the above. Thanks. |
Thanks (again!) @samhforbes. Great to have JOSS and the opportunity to publish software-related work. @Kevin-Mattheus-Moerman, I have made the corrections you required (thanks for this). The new version of the paper has been uploaded on the master branch. |
@editorialbot generate pdf |
@pydemull okay all looks good now, thanks for making those changes |
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@pydemull congratulations on this publication in JOSS! @samhforbes Thanks for editing this submission! Special thanks also to the reviewers: @elimillera and @angerhang |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @pydemull (Pierre-Yves de Müllenheim)
Repository: https://github.com/pydemull/activAnalyzer
Branch with paper.md (empty if default branch):
Version: v1.1.0
Editor: @samhforbes
Reviewers: @elimillera, @angerhang
Archive: 10.5281/zenodo.7384191
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@elimillera & @spitschan & @angerhang, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @samhforbes know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @angerhang
📝 Checklist for @elimillera
The text was updated successfully, but these errors were encountered: