Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: LightLogR: Reproducible analysis of personal light exposure data #7377

Closed
editorialbot opened this issue Oct 20, 2024 · 43 comments
Assignees
Labels
pre-review R TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Oct 20, 2024

Submitting author: @JZauner (Johannes Zauner)
Repository: https://github.com/tscnlab/LightLogR
Branch with paper.md (empty if default branch): paper
Version: v0.4.1
Editor: @rwegener2
Reviewers: @cansavvy, @welch16
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/3a1057dccd315b7eb8683c1b969402e2"><img src="https://joss.theoj.org/papers/3a1057dccd315b7eb8683c1b969402e2/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/3a1057dccd315b7eb8683c1b969402e2/status.svg)](https://joss.theoj.org/papers/3a1057dccd315b7eb8683c1b969402e2)

Author instructions

Thanks for submitting your paper to JOSS @JZauner. Currently, there isn't a JOSS editor assigned to your paper.

@JZauner if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Oct 20, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.07 s (1569.0 files/s, 370264.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSV                              2              0              0          11432
R                               81            773           3410           5171
Markdown                        10            348              0           1107
Rmd                              5            472            619            579
YAML                             4             22              9            184
TeX                              1             17              0            163
-------------------------------------------------------------------------------
SUM:                           103           1632           4038          18636
-------------------------------------------------------------------------------

Commit count by author:

   119	Johannes Zauner
    71	Jzauner
    22	Manuel Spitschan
    22	steffenhartmeyer
     3	Steffen Hartmeyer

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1502

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1111/jsr.14225 is OK
- 10.1177/14771535241248540 is OK
- 10.1101/2024.02.11.24302663 is OK
- 10.1177/14771535221103258 is OK
- 10.1101/2024.10.02.616112 is OK
- 10.1123/jmpb.2018-0063 is OK
- 10.12688/wellcomeopenres.20557.1 is OK
- 10.1177/20552076221144858 is OK
- 10.20944/preprints202409.1285.v1 is OK
- 10.1016/j.measurement.2024.114909 is OK
- 10.1038/sdata.2016.18 is OK
- 10.21203/rs.3.rs-3771881/v1 is OK
- 10.5281/zenodo.13839724 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: LightLogR: Process Data from Wearable Light Logger...
- No DOI given, and none found for title: LightLogR: Process Data from Wearable Light Logger...
- No DOI given, and none found for title: LightLogR: Process Data from Wearable Light Logger...
- No DOI given, and none found for title: LightLogR: Tutorial: The whole game
- No DOI given, and none found for title: ggplot2: Elegant Graphics for Data Analysis

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

mhealthtools: A Modular R Package for Extracting Features from Mobile and Wearable Sensor Data
Submitting author: @philerooski
Handling editor: @trallard (Retired)
Reviewers: @Ebedthan, @AKuederle
Similarity score: 0.6772

activAnalyzer: An R Shiny app to analyse ActiGraph accelerometer data and to implement the use of the PROactive Physical Activity in COPD instruments
Submitting author: @pydemull
Handling editor: @samhforbes (Active)
Reviewers: @elimillera, @angerhang
Similarity score: 0.6750

lightr: import spectral data and metadata in R
Submitting author: @bisaloo
Handling editor: @danielskatz (Active)
Reviewers: @danielskatz
Similarity score: 0.6684

Devicely: A Python package for reading, timeshifting and writing sensor data
Submitting author: @arianesasso
Handling editor: @prashjha (Active)
Reviewers: @luciorq, @djmitche
Similarity score: 0.6650

PupillometryR: An R package for preparing and analysing pupillometry data
Submitting author: @samhforbes
Handling editor: @oliviaguest (Active)
Reviewers: @paulinepalma, @Athanasiamo
Similarity score: 0.6593

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @rwegener2 as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@rwegener2
Copy link

@editorialbot add me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @rwegener2 is now the editor

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

lightr: import spectral data and metadata in R
Submitting author: @bisaloo
Handling editor: @danielskatz (Active)
Reviewers: @danielskatz
Similarity score: 0.6764

mhealthtools: A Modular R Package for Extracting Features from Mobile and Wearable Sensor Data
Submitting author: @philerooski
Handling editor: @trallard (Retired)
Reviewers: @Ebedthan, @AKuederle
Similarity score: 0.6728

SleepPy: A python package for sleep analysis from accelerometer data
Submitting author: @elyiorgos
Handling editor: @lheagy (Retired)
Reviewers: @eskofier, @ikarosilva, @nhejazi
Similarity score: 0.6693

PupillometryR: An R package for preparing and analysing pupillometry data
Submitting author: @samhforbes
Handling editor: @oliviaguest (Active)
Reviewers: @paulinepalma, @Athanasiamo
Similarity score: 0.6642

Devicely: A Python package for reading, timeshifting and writing sensor data
Submitting author: @arianesasso
Handling editor: @prashjha (Active)
Reviewers: @luciorq, @djmitche
Similarity score: 0.6606

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@JZauner
Copy link

JZauner commented Oct 28, 2024

Dear JOSS Team,

Here are suggestions for reviewers based on the provided database:

jamesmbaazam
petermacp
Tgerke
hantswilliams
epiben

Thanks and best regards

@rwegener2
Copy link

👋🏻 @petermacp and @tgerke, would either of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@JZauner
Copy link

JZauner commented Oct 31, 2024

Dear JOSS Team,

We internally discussed changing the license of LightLogR to a more permissive one, i.e. to MIT instead of GPL. As the licence is documented in the paper, it would be great if we can change this in the paper and the paper branch and merge it to the main branch, so that the license change does not happen after publication.
Would that be acceptable to JOSS? If so, please give a short indication and I will update the branch's license and the relevant part in the manuscript.
Best, Johannes

@rwegener2
Copy link

Hi @JZauner! Not a problem. Feel free to change the license, just merge into the branch.

@rwegener2
Copy link

rwegener2 commented Nov 7, 2024

👋🏻 @hantswilliams and @epiben, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@rwegener2
Copy link

👋🏻 @jamesmbaazam or @stemangiola, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@jamesmbaazam
Copy link

Hi @rwegener2 thanks for the invite but I am unavailable to do this review at this time.

@rwegener2
Copy link

No problem @jamesmbaazam. Thanks for the response!

@rwegener2
Copy link

👋🏻 @cansavvy or @amalthomas111, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@cansavvy
Copy link

👋🏻 @cansavvy or @amalthomas111, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

I won't be able to have the bandwidth for this immediately but I am interested. What's the deadline?

@rwegener2
Copy link

rwegener2 commented Nov 27, 2024

I won't be able to have the bandwidth for this immediately but I am interested. What's the deadline?

Thanks for the response @cansavvy! We ask that reviewers do their best to complete reviews 2-4 weeks after the review has begin.

We don't start the review until both reviewers are identified, so if you'd like I can continue looking for another reviewer and re-ping you when we are closer to starting the review. Would that work?

@cansavvy
Copy link

cansavvy commented Nov 27, 2024

2 - 4 weeks is doable. And yes that sounds good. In that case, I'm available to do this review.

@rwegener2
Copy link

2 - 4 weeks is doable. And yes that sounds good. In that case, I'm available to do this review.

Wonderful, thanks @cansavvy! I'll add you as a reviewer now, then, but if you prefer to stay off the "accepted" reviewer list for now just let me know and I'll remove you and re-request a review later.

@rwegener2
Copy link

@editorialbot add @cansavvy as reviewer

@editorialbot
Copy link
Collaborator Author

@cansavvy added to the reviewers list!

@rwegener2
Copy link

👋🏻 @Wytamma or @snamburi3, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@Wytamma
Copy link

Wytamma commented Dec 5, 2024

Hi @rwegener2 - thanks for the invitation to review. I’m going on leave until the new year on the 18th. Not sure if I’ll be able to get this done before then, but can give it a go if @snamburi3 is unavailable.

@rwegener2
Copy link

Hi @Wytamma thanks for the reply! If you think you can complete the review by the 18th I'd be happy to add you as a reviewer. If not, no worries. We have a database of reviewers and I'll go ahead and reach out to another reviewer from our database.

@Wytamma
Copy link

Wytamma commented Dec 8, 2024

I don’t think I can commit to it so will have to pass on this one. But thanks again for the invitation.

@rwegener2
Copy link

I don’t think I can commit to it so will have to pass on this one. But thanks again for the invitation.

No worries. Thanks for the response, @Wytamma!

@rwegener2
Copy link

👋🏻 @zhanzmr or @welch16, would either of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@welch16
Copy link

welch16 commented Dec 17, 2024

@rwegener2 , I have chance to review the manuscript

@zhanzmr
Copy link

zhanzmr commented Dec 17, 2024

@rwegener2 , I am also available to review the manuscript. Thanks.

@rwegener2
Copy link

@editorialbot add @welch16 as reviewer

@editorialbot
Copy link
Collaborator Author

@welch16 added to the reviewers list!

@rwegener2
Copy link

Wow, thanks for such a speedy reply both @welch16 and @zhanzmr!

As the first to reply I've added @welch16 to the list of reviewers. @zhanzmr we would love to have your expertise as a third reviewer, if you would like. I'm sure your input would improve the quality of this submission.

@zhanzmr I will note that JOSS only requires two reviewers and adding you as a third reviewer is not a JOSS requirement. As such, if you would like to pass on this review that is totally fine and I'm sure JOSS will call on your expertise for a future submission.

Either way is excellent for me - @zhanzmr just let me know if you'd like to be added as a reviewer to this submission, or if you prefer hold off and wait to review a different JOSS submission. Thanks!

@zhanzmr
Copy link

zhanzmr commented Dec 18, 2024

Hi @rwegener2 , No worries! I can pass this one and wait for next one. Thanks so much for the invite!

@rwegener2
Copy link

No worries! I can pass this one and wait for next one. Thanks so much for the invite!

Sounds good @zhanzmr. Thanks for being willing to review, we really appreciate it!

@rwegener2
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7601.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review R TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

9 participants