Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: PCRedux: A Quantitative PCR Machine Learning Toolkit #4390

Closed
editorialbot opened this issue May 13, 2022 · 35 comments
Closed

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented May 13, 2022

Submitting author: @devSJR (Stefan Rödiger)
Repository: https://github.com/PCRuniversum/PCRedux
Branch with paper.md (empty if default branch):
Version: 1.1-2
Editor: @csoneson
Reviewers: @jaybee84, @markziemann
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/860ed94423d2d9908209c37ed8aec46b"><img src="https://joss.theoj.org/papers/860ed94423d2d9908209c37ed8aec46b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/860ed94423d2d9908209c37ed8aec46b/status.svg)](https://joss.theoj.org/papers/860ed94423d2d9908209c37ed8aec46b)

Author instructions

Thanks for submitting your paper to JOSS @devSJR. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @csoneson.

@devSJR if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@openjournals openjournals deleted a comment from editorialbot May 13, 2022
@openjournals openjournals deleted a comment from editorialbot May 13, 2022
@arfon
Copy link
Member

arfon commented May 13, 2022

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Couldn't check the bibtex because branch name is incorrect: joss

@arfon
Copy link
Member

arfon commented May 13, 2022

@editorialbot generate pdf

@arfon
Copy link
Member

arfon commented May 13, 2022

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.07 s (1269.5 files/s, 208324.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            23           1123            261           3692
CSS                              3            360             73           1961
TeX                              2            144             10           1890
R                               41            399           1086           1659
Markdown                         4             77              0            471
JavaScript                       5             59             27            287
SVG                              2              0              1            122
YAML                             3             11              0             52
Rmd                              1              1             18              0
-------------------------------------------------------------------------------
SUM:                            84           2174           1476          10134
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 2253

@openjournals openjournals deleted a comment from editorialbot May 13, 2022
@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arfon
Copy link
Member

arfon commented May 13, 2022

@editorialbot invite @csoneson as editor

👋 @csoneson – would you be able to edit this submission for us?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@devSJR
Copy link

devSJR commented May 13, 2022

@editorialbot
suggestions for potential reviewers
dombennett
andremrsantos
seaaan

@csoneson
Copy link
Member

@editorialbot assign @csoneson as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @csoneson is now the editor

@csoneson
Copy link
Member

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@csoneson
Copy link
Member

👋🏻 @devSJR - thanks for submitting to JOSS! I will handle your submission, and start by finding two reviewers.

I noticed that your paper is significantly longer than the JOSS standards - typical JOSS papers should be between 250 and 1,000 words (see https://joss.readthedocs.io/en/latest/submitting.html#what-should-my-paper-contain), while yours is over 2,200 words. Could you try to shorten this to get at closer to the guidelines? Thanks!

@csoneson
Copy link
Member

👋🏻 @seaaan, @dvanic, @rmflight - would (two of) you be interested in reviewing this submission for JOSS?

PCRedux: A Quantitative PCR Machine Learning Toolkit

@devSJR
Copy link

devSJR commented May 15, 2022

Dear @csoneson, thanks for handling this. When we were preparing the paper we read the guidelines. Additionally, we looked other JOSS papers, which appeared longer than the guidelines. Guess we were wrong about this. Our appologies. We can certainly shorten the paper.

I would like to mention that there is a long vignette cited as Rödiger et al. 2022. It is not part of the package because it is larger (file size) than CRAN allows.

Kind regards,

@devSJR

@seaaan
Copy link

seaaan commented May 16, 2022 via email

@rmflight
Copy link
Member

Hi @csoneson, thank you for considering me. However, upon looking over the package, I don't think I have the theoretical knowledge about PCR to know what exactly this package is doing and if it will be useful to someone who actually does do PCR on the regular.

@csoneson
Copy link
Member

@rmflight - no worries, thanks for the quick response!

@seaaan - thanks a lot for responding as well, I may get back to you!

@csoneson
Copy link
Member

👋🏻 @jaybee84, @chrisamiller - would you be interested in reviewing this submission for JOSS?

PCRedux: A Quantitative PCR Machine Learning Toolkit

@chrisamiller
Copy link

This one is a little bit outside of my expertise, sorry. Happy to be considered for future reviews, though!

@devSJR
Copy link

devSJR commented May 19, 2022

@csoneson I suggested some reviewers from the list provided by JOSS. At least one of the potential reviewers has a PCR background. Maybe this helps.

@jaybee84
Copy link

I am happy to review this paper :)

@csoneson
Copy link
Member

Thank you @jaybee84! I will assign you and start the review issue once we have secured one more reviewer.

@chrisamiller - no problem, thanks for responding!

@csoneson
Copy link
Member

👋🏻 @markziemann, @DomBennett - would one of you be available and interested in reviewing this submission for JOSS?

PCRedux: A Quantitative PCR Machine Learning Toolkit

@markziemann
Copy link

@csoneson Yes I can do it within 14 days

@csoneson
Copy link
Member

Awesome, thanks @markziemann! I'm going to assign the reviewers now and officially start the review.

@seaaan - I think we are set for this submission, I hope we can reach out to you for another review in the future! Thanks!

@csoneson
Copy link
Member

@editorialbot add @jaybee84 as reviewer

@editorialbot
Copy link
Collaborator Author

@jaybee84 added to the reviewers list!

@csoneson
Copy link
Member

@editorialbot add @markziemann as reviewer

@editorialbot
Copy link
Collaborator Author

@markziemann added to the reviewers list!

@csoneson
Copy link
Member

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #4407.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants