-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: FlexWing-ROM: A matlab framework for data-driven reduced-order modeling of flexible wings #4211
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@oriolcg, @omtazi this is where the review takes place. Here are our review guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Once you are ready you may post the following comment here (on its own, no other text): This will create a checklist for you that will guide you through the process. In essence you will test the software and review the short paper and go through the checklist. Please do not hesitate to contact me if you have any questions. Thanks again for your help! |
Review checklist for @omtaziConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@oriolcg thanks again for your help with this review. Let me know if you have any questions. Are you able to start the review process too? You can call |
@oriolcg 👋 let me know if I can help. |
Review checklist for @oriolcgConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@Kevin-Mattheus-Moerman, where do I post comments on the review? Directly to the repository? |
@oriolcg apologies for the slow response. You can comment on small ish things here but if they are larger issues I recommend you open an issue on the project repository on that and then link to it here. Let me know if you have any other questions. |
Hello @Kevin-Mattheus-Moerman @oriolcg , I'm having trouble running the example1 and example2 codes. I get the following message when I run example2_NACA6418_unsteadyFSI.m . Do you have this too ? `Unable to resolve the name 'parallel.Settings'. Error in Assembly/adjust_parallel_settings (line 26) Error in Assembly/set.parallelized (line 22) Error in Assembly (line 16) Error in runYetAnotherFEcode (line 147) Error in generateWingModelStructure (line 1374) Error in example2_NACA6418_unsteadyFSI (line 46) |
@urban-fasel can you help @omtazi to address this issue? ☝️ |
Hi @Kevin-Mattheus-Moerman, yes! And sorry for not directly replying to the issue. Hi @omtazi, the issue is related to the "yetAnotherFEcode" that we use to build the FE model of the wing. This package uses the "Parallel Computing Toolbox". If you install the toolbox, you should be able to run the code. In case other toolboxes are missing, the required toolboxes for e.g. example2 can be found and printed in the command line like this: I hope this helps and please let me know if you still get the error message. |
@omtazi can you test this approach ☝️ |
@omtazi 👋 |
1 similar comment
@omtazi 👋 |
@urban-fasel , I get the following error when executing the code:
Please, state in the README the required toolbox that should be installed before executing |
@editorialbot generate pdf |
@omtazi @frederickgosselin can you please start the review process? Thanks |
@oriolcg thanks again for your help here. I see you encountered a "missing toolboxes" type of error. Can you install those and proceed or is this an obstacle? @urban-fasel please do add toolbox requirements to the README. |
@editorialbot generate pdf |
@urban-fasel thanks for processing those changes. All looks good now. At this point the review is finished and both reviewers have recommended accept. Next, before we can proceed to formal acceptance, please can you work on the following:
Next ensure that the following ZENODO aspects are correct (you may need to manually edit these):
Finally:
Let me know if you have any questions. |
@Kevin-Mattheus-Moerman I archived a copy of the software to ZENODO. The DOI is 10.5281/zenodo.7419465. The tagged release is v1.0.0. Thanks again for your review! |
@editorialbot set 10.5281/zenodo.7419465 as archive |
Done! Archive is now 10.5281/zenodo.7419465 |
@editorialbot recommend-accept |
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3789, then you can now move forward with accepting the submission by compiling again with the command |
|
@urban-fasel can you check those potentially missing DOI's? ☝️ You can call |
@editorialbot check references |
|
@Kevin-Mattheus-Moerman I just updated the bib file, all DOIs are ok now. |
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@openjournals/dev hmm the DOI does not resolve yet. Can you see what's wrong? |
The PDF is now working for me too |
@danielskatz thanks. Yes it looks good now. I usually wait until the PDF is there too. It did take an awful lot longer than usual. |
@urban-fasel congratulations on this publication in JOSS! @omtazi thank you for reviewing this work! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @urban-fasel (Urban Fasel)
Repository: https://github.com/urban-fasel/FlexWingROM
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @Kevin-Mattheus-Moerman
Reviewers: @omtazi, @Kevin-Mattheus-Moerman
Archive: 10.5281/zenodo.7419465
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@oriolcg & @omtazi, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Kevin-Mattheus-Moerman know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @omtazi
📝 Checklist for @Kevin-Mattheus-Moerman
The text was updated successfully, but these errors were encountered: