Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: FlexWing-ROM: A matlab framework for data-driven reduced-order modeling of flexible wings #4106

Closed
whedon opened this issue Jan 28, 2022 · 35 comments
Assignees
Labels
GLSL Matlab pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@whedon
Copy link

whedon commented Jan 28, 2022

Submitting author: @urban-fasel (Urban Fasel)
Repository: https://github.com/urban-fasel/FlexWingROM
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @Kevin-Mattheus-Moerman
Reviewers: @oriolcg, @omtazi
Managing EiC: Arfon Smith

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/70cc0af28cda2015132999136ce38eee"><img src="https://joss.theoj.org/papers/70cc0af28cda2015132999136ce38eee/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/70cc0af28cda2015132999136ce38eee/status.svg)](https://joss.theoj.org/papers/70cc0af28cda2015132999136ce38eee)

Author instructions

Thanks for submitting your paper to JOSS @urban-fasel. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @Kevin-Mattheus-Moerman.

@urban-fasel if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jan 28, 2022

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jan 28, 2022

Wordcount for paper.md is 1430

@whedon
Copy link
Author

whedon commented Jan 28, 2022

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=2.37 s (243.0 files/s, 61693.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
MATLAB                         520           7153          15352         106601
HTML                            37           1792           3627           9769
Markdown                         7            130              0            445
XSLT                             1             64             25            311
TeX                              1             30              0            277
GLSL                             2             15              7            155
XML                              5             12             28            118
CSS                              1             14              0             57
YAML                             1              0              0             11
-------------------------------------------------------------------------------
SUM:                           575           9210          19039         117744
-------------------------------------------------------------------------------


Statistical information for the repository 'd2ff388ae72b4622554afdaf' was
gathered on 2022/01/28.
No commited files with the specified extensions were found.

@whedon
Copy link
Author

whedon commented Jan 28, 2022

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1017/S0962492902000077 is OK
- 10.1146/annurev.fluid.37.061903.175743 is OK
- 10.1016/j.jcp.2017.02.027 is OK
- 10.2514/3.55530 is OK
- 10.1117/12.776137 is OK
- 10.1016/j.paerosci.2012.06.001 is OK
- 10.1017/jfm.2013.163 is OK
- 10.2514/1.J055193 is OK

MISSING DOIs

- 10.1088/1361-665x/aa7c87 may be a valid DOI for title: Aerostructural optimization of a morphing wing for airborne wind energy applications
- 10.2514/1.j059621 may be a valid DOI for title: Concurrent Design and Flight Mission Optimization of Morphing Airborne Wind Energy Wings
- 10.1098/rspa.2020.0079 may be a valid DOI for title: Data-driven nonlinear aeroelastic models of morphing wings for control
- 10.1002/rnc.3586 may be a valid DOI for title: A method to construct reduced-order parameter-varying models
- 10.1016/j.ast.2021.106821 may be a valid DOI for title: The balanced mode decomposition algorithm for data-driven LPV low-order models of aeroservoelastic systems
- 10.1145/800186.810616 may be a valid DOI for title: A two-dimensional interpolation function for irregularly-spaced data
- 10.2514/1.j052715 may be a valid DOI for title: Aero-structural optimization of three-dimensional adaptive wings with embedded smart actuators
- 10.2514/1.j058019 may be a valid DOI for title: Reduced-order dynamic model of a morphing airborne wind energy aircraft
- 10.1242/jeb.204.12.2073 may be a valid DOI for title: Shape, flapping and flexion: wing and fin design for forward flight
- 10.1038/35089071 may be a valid DOI for title: Spanwise flow and the attachment of the leading-edge vortex on insect wings
- 10.1126/science.1142281 may be a valid DOI for title: Bat flight generates complex aerodynamic tracks
- 10.2514/1.36694 may be a valid DOI for title: Aeromechanics of membrane wings with implications for animal flight

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Jan 28, 2022

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arfon
Copy link
Member

arfon commented Jan 30, 2022

👋 @Kevin-Mattheus-Moerman @prashjha – I know you both have pretty full (editorial) plates right now. Are there any other JOSS editors you think could be a good fit here?

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jan 30, 2022
@Kevin-Mattheus-Moerman
Copy link
Member

@arfon If this remains waitlisted for too long feel free to assign it to me, I can take it if needed.

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Feb 5, 2022
@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign me as editor

@whedon
Copy link
Author

whedon commented Feb 5, 2022

OK, the editor is @Kevin-Mattheus-Moerman

@Kevin-Mattheus-Moerman
Copy link
Member

@urban-fasel thanks for this submission. I am currently looking for reviewers. If you can suggest any reviewers that would be helpful too. You can mention their github handle (without the @ symbol) here.

Could you clarify if this submission is compatible with Octave? Or does it require special MATLAB functions/toolboxes that are note part of Octave. I ask this as some reviewers can only review Octave rather than MATLAB submissions. Thanks.

@urban-fasel
Copy link

Hi @Kevin-Mattheus-Moerman, thanks for being the editor of our submission!
Some potential reviewers from the joss_reviewers list: vaishnavtv, wahls, mbudisic, balaje
and some additional potential reviewers: nairaditya, ben-herrmann, dylaneij, rschmehl, marconij
The submission is not compatible with Octave as it uses some functions that are not implemented in Octave yet.

@Kevin-Mattheus-Moerman
Copy link
Member

Thanks @urban-fasel I'll have a look at those potential reviewers

@Kevin-Mattheus-Moerman
Copy link
Member

@weymouth I was wondering if this submission on flexible wings featuring FSI is of interest to you and if you could review it for JOSS. It does require MATLAB though. If you are not available/able, perhaps you could suggest a colleague? Thanks.

Short paper: https://github.com/openjournals/joss-papers/blob/joss.04106/joss.04106/10.21105.joss.04106.pdf
Software: https://github.com/urban-fasel/FlexWingROM

@weymouth
Copy link

I don't use/have MATLAB. Looks interesting though.

@Kevin-Mattheus-Moerman
Copy link
Member

@oriolcg
Copy link

oriolcg commented Feb 21, 2022

HI @Kevin-Mattheus-Moerman , I'll be happy to review it, but I'll need some guidance on the process.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @oriolcg as reviewer

@whedon
Copy link
Author

whedon commented Feb 22, 2022

OK, @oriolcg is now a reviewer

@Kevin-Mattheus-Moerman
Copy link
Member

@oriolcg this is a prereview issue where we assign reviewers. Once we have at least two reviewers I'll trigger a review issue. In the review issue you'll have a checklist to go through which will guide you through the review process. Here is an example of a finished review issue:
#3053

The process should be fairly smooth and self-explanatory, but if you want to learn more you can read all about it here too:
https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

Let me know if you have any questions. Thanks for your help!

@Kevin-Mattheus-Moerman
Copy link
Member

@chennachaos I feel like I'm close to "over inviting" you to review for JOSS, but do let me know if this work is your cup of tea, and would, despite the reliance on MATLAB, be interesting to review.

@Kevin-Mattheus-Moerman
Copy link
Member

@Nicola-Fonzi @dciliberti @Philipp-Conen @JaroslavHron @albansouche would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS). The work is entitled: A matlab framework for data-driven reduced-order modeling of flexible wings.

Note this submission is not Octave compatible so reviewing it does require a MATLAB installation.

JOSS reviews take place on GitHub and focus on the review and evaluation of the software as well as a very short paper.

This is a pre-review issue where we find and assign reviewers. If you are interested I'll add you as a reviewer and once we have sufficient reviewers I'll trigger a dedicated review issue (see this example of a finished review issue: #2089).

Thanks.

@Nicola-Fonzi
Copy link

Hi @Kevin-Mattheus-Moerman and thank you for being the reviewer of the paper! I am one of the authors so I guess I have to decline your invitation to review, but feel free to contact me in the future for other works

@Kevin-Mattheus-Moerman
Copy link
Member

@Nicola-Fonzi my sincere apologies. I see you are on the paper, sorry I did not see your name as a contributor for the software (https://github.com/urban-fasel/FlexWingROM/graphs/contributors) so accidentally invited you.

@Nicola-Fonzi
Copy link

No worries, and thank you again for being the editor

@dciliberti
Copy link

dciliberti commented Feb 23, 2022 via email

@JaroslavHron
Copy link

Hi @Kevin-Mattheus-Moerman - I am sorry but right now I am busy with other review duties.

@chennachaos
Copy link

Hi @Kevin-Mattheus-Moerman! Thanks for the invite! Looks very interesting but I have to skip this one.

@Kevin-Mattheus-Moerman
Copy link
Member

@chennachaos 👍 no worries. Yeah you already deserve a medal for your other review efforts. Thanks for getting back to me.

@Kevin-Mattheus-Moerman
Copy link
Member

@frederickgosselin thanks for your comment on Twitter it would be great to assign yourself or your student as reviewer. Let me know how to proceed.

@omtazi
Copy link

omtazi commented Feb 28, 2022

Hello @Kevin-Mattheus-Moerman, I am a student of @frederickgosselin and I would be happy to review this work.

@frederickgosselin
Copy link

Hi @Kevin-Mattheus-Moerman, Omar Tazi-Labzour @omtazi is a graduate student working with me at Polytechnique Montreal. I'll give him a hand with the review.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot add @omtazi as reviewer

@editorialbot
Copy link
Collaborator

@omtazi added to the reviewers list!

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot start review

@editorialbot
Copy link
Collaborator

OK, I've started the review over in #4211.

@editorialbot editorialbot added the Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials label Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GLSL Matlab pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests