-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: home2park: An R package to assess the spatial provision of urban parks #3609
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @aelissa, @nickbearman it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Wordcount for |
|
|
👋 @xp-song @aelissa @nickbearman this is the review thread for the paper. All of our communications will happen here from now on. Both reviewers have checklists at the top of this thread with the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use Whedon (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@martinfleis) if you have any questions/concerns. |
👋 @nickbearman, please update us on how your review is going (this is an automated reminder). |
👋 @aelissa, please update us on how your review is going (this is an automated reminder). |
Hi all, I am having a look at this now. |
@whedon commands |
Here are some things you can ask me to do:
|
@martinfleis I think my invitation has expired, I can't edit the checklist and when I click the link https://github.com/openjournals/joss-reviews/invitations GitHub said the invitation had expired. Thanks! |
@whedon re-invite @nickbearman as reviewer |
OK, the reviewer has been re-invited. @nickbearman please accept the invite by clicking this link: https://github.com/openjournals/joss-reviews/invitations |
@nickbearman I have invited you again. Let me know if the issue persists. Thanks! |
@martinfleis Thanks very much, it works now! |
I have a query reinstallation. To verify that it should do a clean install, I tried installing it on RStudio.Cloud. That, however, did not work:
Given this needs to be complied, does anyone know if that should be possible on RStudio.Cloud? |
Currently I can't really test the software without a link to the 'Get started' tutorial. |
Thanks for pointing out the dead link, I've amended it in commit 91e1f09. The website also contains more detailed explanations of the package: https://ecological-cities.github.io/home2park/ I'll have a look at testing the installation on other environments and see if it works, perhaps using conda |
I'm not too experienced with testing with 'clean' installation myself (other than the R-CMD-Check, which works fine), but based on this post, I managed to install it using a new conda environment: In my command line (Mac Terminal):
To install packages from github, install R package
To ensure that dependency R package
Load R, and run the following:
|
Thanks @xp-song for the notes re installation. I'm happy with this. @martinfleis any comments? |
@whedon set 10.5281/zenodo.5516698 as archive |
OK. 10.5281/zenodo.5516698 is the archive. |
@whedon set v0.1.1 as version |
OK. v0.1.1 is the version. |
@whedon generate pdf |
Thank you @xp-song. I'm going to hand this over now to the associate EiC on rotation for the final steps. |
@whedon recommend-accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2594 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2594, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
I'm sorry @xp-song, I'm afraid I can't do that. That's something only editor-in-chiefs are allowed to do. |
whoops, embarrassing mistake. |
@xp-song Don't worry, it happens all the time! It doesn't say who should input that command, after all! |
I see your zenodo archive is made and in place, your version is up to date, and your paper looks great! We can proceed! |
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations @xp-song! Thank you again @aelissa and @nickbearman for you valuable reviews! |
Thanks all, especially for your reviews @aelissa and @nickbearman and for being so thorough as handling editor @martinfleis! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @xp-song (Xiao Ping Song)
Repository: https://github.com/ecological-cities/home2park
Version: v0.1.1
Editor: @martinfleis
Reviewer: @aelissa, @nickbearman
Archive: 10.5281/zenodo.5516698
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@aelissa & @nickbearman, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @martinfleis know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @aelissa
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @nickbearman
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: