Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Whereabouts: Fast, Accurate, Open-Source Geocoding in Python #7186

Closed
editorialbot opened this issue Sep 6, 2024 · 33 comments
Closed
Labels
pre-review Python query-scope Submissions of uncertain scope for JOSS rejected Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @ajl2718 (Alexander Lee)
Repository: https://www.github.com/ajl2718/whereabouts
Branch with paper.md (empty if default branch):
Version: V0.3.14
Editor: Pending
Reviewers: Pending
Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/65276e4acba468c690621e2a8274c16a"><img src="https://joss.theoj.org/papers/65276e4acba468c690621e2a8274c16a/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/65276e4acba468c690621e2a8274c16a/status.svg)](https://joss.theoj.org/papers/65276e4acba468c690621e2a8274c16a)

Author instructions

Thanks for submitting your paper to JOSS @ajl2718. Currently, there isn't a JOSS editor assigned to your paper.

@ajl2718 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Sep 6, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (2185.7 files/s, 116747.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SQL                             21             13              9           1078
Python                          16            222            424            770
Markdown                         2             54              0            126
reStructuredText                 6             63             28             76
YAML                             5              4              4             71
TeX                              2              2              0             39
TOML                             1              2              0             30
JSON                             3              0              0             28
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            58            372            473           2253
-------------------------------------------------------------------------------

Commit count by author:

   109	alex2718
   107	ajl2718
     8	Alex
     1	Alex Lee

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- None

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- 10.1007/978-981-13-0292-3_7 may be a valid DOI for title: Exploiting Redundancy, Recurrence and Parallelism:...
- 10.1145/3269206.3272016 may be a valid DOI for title: Scalable Entity Resolution Using Probabilistic Sig...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 780

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

@ajl2718
Copy link

ajl2718 commented Sep 7, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

DeGAUSS: Decentralized Geomarker Assessment for Multi-Site Studies
Submitting author: @cole-brokamp
Handling editor: @pjotrp (Retired)
Reviewers: @vsoch, @george-githinji
Similarity score: 0.7365

tidygeocoder: An R package for geocoding
Submitting author: @jessecambon
Handling editor: @elbeejay (Active)
Reviewers: @cole-brokamp, @tsamsonov
Similarity score: 0.7311

BigX: A geographical dataset visualisation tool
Submitting author: @geekysquirrel
Handling editor: @hugoledoux (Active)
Reviewers: @liberostelios, @jvdkwast
Similarity score: 0.7117

home2park: An R package to assess the spatial provision of urban parks
Submitting author: @xp-song
Handling editor: @martinfleis (Active)
Reviewers: @aelissa, @nickbearman
Similarity score: 0.6915

localcovid19now: processing and mapping COVID-19 case data at subnational scales
Submitting author: @sjbeckett
Handling editor: @galessiorob (Active)
Reviewers: @richelbilderbeek, @mbkumar, @welch16, @Epic19mz
Similarity score: 0.6908

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@ajl2718
Copy link

ajl2718 commented Sep 8, 2024

Suggested reviewer: musabgultekin

@ajl2718
Copy link

ajl2718 commented Sep 8, 2024

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @ajl2718, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@ajl2718
Copy link

ajl2718 commented Sep 8, 2024

@editorialbot list reviewers

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@ajl2718
Copy link

ajl2718 commented Sep 8, 2024

@editorialbot list reviewers

@editorialbot
Copy link
Collaborator Author

Please log in the JOSS Reviewers site to search through the list of current reviewers.

@ajl2718
Copy link

ajl2718 commented Sep 8, 2024

@editorialbot add @musabgultekin as reviewer

@editorialbot
Copy link
Collaborator Author

I'm sorry @ajl2718, I'm afraid I can't do that. That's something only editors are allowed to do.

@ajl2718
Copy link

ajl2718 commented Sep 8, 2024

@musabgultekin would you be happy to review? I'm not sure if there is anything I need to do at my end to ensure you are added as a reviewer.

@musabgultekin
Copy link

Yes I'm happy to review. I think an editor needs to decide that in the end.

@crvernon
Copy link

crvernon commented Sep 9, 2024

@ajl2718 - please do not invite reviewers in this thread. I will assign a topic editor to this submission after it has been deemed appropriate for review. The topic editor will then find reviewers that they think are a best fit for this submission and may reach out to you for suggestions. Thanks.

@crvernon
Copy link

crvernon commented Sep 9, 2024

@editorialbot query scope

👋 @ajl2718 - I am going to run this one by our larger editorial board due to it's smaller code base to ensure it meets our substantial scholarly effort requirement. This should take about two weeks at the most. I'll let you know what I hear back ASAP.

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Sep 9, 2024
@ajl2718
Copy link

ajl2718 commented Sep 10, 2024

Thanks @crvernon

@ajl2718
Copy link

ajl2718 commented Sep 23, 2024

Hi @crvernon, just wanted to follow up to see if you had any updates on the review for this paper.

@crvernon
Copy link

Hi @ajl2718 - the scope query is almost complete. We are just finalizing discussion on a few items. I'll be back in touch ASAP.

@crvernon
Copy link

👋 @ajl2718 - could you provide a bit more information about the algorithms paper that was published (https://doi.org/10.1145/3269206.3272016)? Was the code in this submission to JOSS evaluated by reviewers in that paper at all?

@ajl2718
Copy link

ajl2718 commented Oct 15, 2024

Hi @crvernon, no the code for this submission was not evaluated by reviewers in that paper. This package has been developed independently of those papers and I am not claiming to have developed the algorithms myself. The algorithms that I have implemented in the package are based on one described in this paper (https://arxiv.org/abs/1708.01402) which, as I understand it, is itself is derived from the paper you mention above, though focused specifically on postal addresses rather than general record linkage / entity resolution. I have made some small novel modifications to the algorithms described in those papers, in order to better handle spelling variations and reduce storage requirements of the resulting databases. Please let me know if you need any additional information.

@ajl2718
Copy link

ajl2718 commented Oct 26, 2024

Hi @crvernon, is there any update on the scope query?

@arfon
Copy link
Member

arfon commented Nov 1, 2024

@ajl2718 – after discussions amongst the editorial team, we've concluded that this software falls into our 'minor utility' category, and is therefore not in scope for JOSS.

One possible alternative to JOSS is to follow GitHub's guide on how to create a permanent archive and DOI for your software. This DOI can then be used by others to cite your work.

@arfon
Copy link
Member

arfon commented Nov 1, 2024

@editorialbot reject

@editorialbot
Copy link
Collaborator Author

Paper rejected.

@ajl2718
Copy link

ajl2718 commented Nov 2, 2024

Hi @arfon , Thank you for the response. I would like to request that the decision be reconsidered, based on the points below:

  • A similar library, tidygeocoder was accepted to JOSS previously, suggesting that it is within scope.
  • Like tidygeocoder, whereabouts solves the task of geocoding. However, unlike that library, it implements these algorithms as part of the package, rather than relying on existing APIs. Therefore I do not believe whereabouts should be considered a ‘minor utility.’
  • By carrying out geocoding in this way, users can perform these tasks within their own environments, rather than sending (sometimes sensitive) data to external service, which better supports many uses cases, particularly in healthcare.

Please could you reconsider the decision or clarify based on the points described above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python query-scope Submissions of uncertain scope for JOSS rejected Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

5 participants