-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: Whereabouts: Fast, Accurate, Open-Source Geocoding in Python #7186
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
@editorialbot generate pdf |
Five most similar historical JOSS papers: DeGAUSS: Decentralized Geomarker Assessment for Multi-Site Studies tidygeocoder: An R package for geocoding BigX: A geographical dataset visualisation tool home2park: An R package to assess the spatial provision of urban parks localcovid19now: processing and mapping COVID-19 case data at subnational scales |
Suggested reviewer: musabgultekin |
@editorialbot commands |
Hello @ajl2718, here are the things you can ask me to do:
|
@editorialbot list reviewers |
I'm sorry human, I don't understand that. You can see what commands I support by typing:
|
@editorialbot list reviewers |
Please log in the JOSS Reviewers site to search through the list of current reviewers. |
@editorialbot add @musabgultekin as reviewer |
I'm sorry @ajl2718, I'm afraid I can't do that. That's something only editors are allowed to do. |
@musabgultekin would you be happy to review? I'm not sure if there is anything I need to do at my end to ensure you are added as a reviewer. |
Yes I'm happy to review. I think an editor needs to decide that in the end. |
@ajl2718 - please do not invite reviewers in this thread. I will assign a topic editor to this submission after it has been deemed appropriate for review. The topic editor will then find reviewers that they think are a best fit for this submission and may reach out to you for suggestions. Thanks. |
@editorialbot query scope 👋 @ajl2718 - I am going to run this one by our larger editorial board due to it's smaller code base to ensure it meets our substantial scholarly effort requirement. This should take about two weeks at the most. I'll let you know what I hear back ASAP. |
Submission flagged for editorial review. |
Thanks @crvernon |
Hi @crvernon, just wanted to follow up to see if you had any updates on the review for this paper. |
Hi @ajl2718 - the scope query is almost complete. We are just finalizing discussion on a few items. I'll be back in touch ASAP. |
👋 @ajl2718 - could you provide a bit more information about the algorithms paper that was published (https://doi.org/10.1145/3269206.3272016)? Was the code in this submission to JOSS evaluated by reviewers in that paper at all? |
Hi @crvernon, no the code for this submission was not evaluated by reviewers in that paper. This package has been developed independently of those papers and I am not claiming to have developed the algorithms myself. The algorithms that I have implemented in the package are based on one described in this paper (https://arxiv.org/abs/1708.01402) which, as I understand it, is itself is derived from the paper you mention above, though focused specifically on postal addresses rather than general record linkage / entity resolution. I have made some small novel modifications to the algorithms described in those papers, in order to better handle spelling variations and reduce storage requirements of the resulting databases. Please let me know if you need any additional information. |
Hi @crvernon, is there any update on the scope query? |
@ajl2718 – after discussions amongst the editorial team, we've concluded that this software falls into our 'minor utility' category, and is therefore not in scope for JOSS. One possible alternative to JOSS is to follow GitHub's guide on how to create a permanent archive and DOI for your software. This DOI can then be used by others to cite your work. |
@editorialbot reject |
Paper rejected. |
Hi @arfon , Thank you for the response. I would like to request that the decision be reconsidered, based on the points below:
Please could you reconsider the decision or clarify based on the points described above? |
Submitting author: @ajl2718 (Alexander Lee)
Repository: https://www.github.com/ajl2718/whereabouts
Branch with paper.md (empty if default branch):
Version: V0.3.14
Editor: Pending
Reviewers: Pending
Managing EiC: Chris Vernon
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @ajl2718. Currently, there isn't a JOSS editor assigned to your paper.
@ajl2718 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: