[REVIEW]: opty: Software For Trajectory Optimization and Parameter Estimation Using Direct Collocation #300
Comments
|
Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @cybanical it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type: |
|
@moorepants @tvdbogert this is where the review process happens |
|
@chrisdembia our formal system currently handles a single reviewer but would you be able to act as a second reviewer on this? |
|
@chrisdembia has also agreed to review. |
|
It is worth nothing that Chris is a co-author of mine (at least in the last few years) and we are good friends. I'm not sure of JOSS rules, but in other journals this would likely be a conflict of interest. FYI. |
|
@moorepants thank you for pointing this out. I will arrange another reviewer. |
|
Just checking in on this. It's been well over a month since I submitted. |
|
👋 @cybanical how are you getting on? Have you started the review process? |
|
Hi Kevin,
I'd be happy to help -- I like the idea of JOSS. I'm on vacation for the
next 3 weeks though, so I wouldn't be able to get it done until ~mid
August. Let me know if that's ok for your timeline.
Ian
…On Sun, Jul 16, 2017 at 7:02 PM, Kevin Mattheus Moerman < ***@***.***> wrote:
@demotu <https://github.com/demotu> @siboles <https://github.com/siboles>
@stavness <https://github.com/stavness> @melund
<https://github.com/melund> @jslee02 <https://github.com/jslee02> I am
looking for an additional reviewer for this submission
<https://github.com/csu-hmc/opty>. Would you be interested in reviewing
this for JOSS <http://joss.theoj.org/>? The review guidelines are here
<http://joss.theoj.org/about#reviewer_guidelines>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#300 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE9qq-xsxqObBv9IusowvUfGFr8dN42xks5sOrK1gaJpZM4OAG_o>
.
|
|
Hey @stavness. Mid-August is fine. By then we'll hopefully have some comments from the first reviewer also. Enjoy your vacation. |
|
I've got a design review this week. Then I can take some time to getting the toolchain up and running. |
|
I'm currently in the middle of moving to a different city so my timeline would be similar to @stavness for settling down at the new place. If it's fine and still needs an additional reviewer, then I'd be happy to participate. Just let me know what you think. |
|
Hi @Kevin-Mattheus-Moerman. Sorry for slow reply. I am also on holiday at the moment. I see you got your second reviewer, but I don't mind helping out some other time if it is biomechanics related. Funny, I had just watched Kyles presentation on Scipy when I got this notification. JOSS is a much needed initiative. |
|
@jslee02 @melund Thanks for getting back to me. It looks like most reviewers have vacation etc. so the mid-august time-line is fine. If this submission is of interest to you, and you have time, I would greatly appreciate if you could also help to review this submission. Our formal system handles 1 "official reviewer". But you can review by leaving comments here (i.e. based on the tick-marks at the top of this issue and http://joss.theoj.org/about#reviewer_guidelines). |
|
Excellent. Looking forward to seeing your comments. |
|
@moorepants Is this only working on a 32-bit install? I just did a fresh anaconda py3.6 64bit windows install and got this error: Also, windows anaconda is not aware of ipopt, cyipopt. Perhaps there could be a bit more clarity/handholding on windows based installation? |
|
@cybanical Thanks, but i do not support Windows at the moment. You can manually install ipopt and then cyipopt and it should work but I do not have the resources to get it working on windows (or providing instructions). I suggest using a linux VM or docker image and using the install instructions in the readme. |
|
@moorepants In that case it might make sense to explicitly state that windows is not supported, rather than give partial instructions for a windows installation - it'd save some headache. |
|
@moorepants can you more clearly state if Windows is actively supported? |
|
I'm pretty sure that the software will work fine on Windows but have never tested it myself. The user would need to manually install all of the dependencies as per their Windows specific instructions. IPOPT, NumPy, SciPy, etc are not necessarily trivial to compile on Windows but one likely can find binaries. I'm happy to do bug fixes wrt to Windows but do not plan on developing installation instructions for all of the dependencies in the opty documentation, as this can be found in the respective packages' docs. I'm happy to make this clearer in the README. |
|
I am reviewing this submission; it will be done by the weekend.
@demotu <https://github.com/demotu>
-
Marcos Duarte
http://demotu.org/
…On Sat, Aug 12, 2017 at 11:05 PM, Kevin Mattheus Moerman < ***@***.***> wrote:
@stavness <https://github.com/stavness> @jslee02
<https://github.com/jslee02> @melund <https://github.com/melund> @demotu
<https://github.com/demotu> we are getting close to mid-august 😄 I hope
those who had a vacation had a good one. If you are still able, would you
be willing to help review this submission? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#300 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADHrnc5vDkc5BnL4_66Bt8lDDJSRwgquks5sXln8gaJpZM4OAG_o>
.
|
|
Thanks @demotu you can leave review comments here. Alternatively you can open issues on the repository for this submission and refer to the issues here. |
|
I installed the software and ran the examples. Everything went smoothly on
ubuntu. Will read the paper this week.
…On Sun, Aug 20, 2017 at 8:17 PM Kevin Mattheus Moerman < ***@***.***> wrote:
Thanks @demotu <https://github.com/demotu> you can leave review comments
here. Alternatively you can open issues on the repository for this
submission <https://github.com/csu-hmc/opty> and refer to the issues here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#300 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE9qq5b3Wc2Eqr_jQyn49SP7HkHVryP2ks5saOjPgaJpZM4OAG_o>
.
|
|
@stavness Great, thanks Ian! Let me know if you have any comments on the other aspects, such as documentation (see tickmarks at the top of this issue). |
|
I tested optpy <https://github.com/csu-hmc/opty> in a Linux machine (Ubuntu
64 bits with a conda installation of Python 3.6).
The examples ran fine, with the exception of the inverted_pendulum.py; I
opened an issue on its repo.
The software and the paper comply with all the JOSS guidelines (
http://joss.theoj.org/about#reviewer_guidelines).
The paper (a summary with a few lines) is in markdown format, not in PDF as
described in the JOSS guidelines, but this is not a problem.
My congratulations to the authors for the development of optpy.
I recommend optpy <https://github.com/csu-hmc/opty> for publication in JOSS.
regards,
-
Marcos Duarte
http://demotu.org/
…On Sun, Aug 20, 2017 at 11:17 PM, Kevin Mattheus Moerman < ***@***.***> wrote:
Thanks @demotu <https://github.com/demotu> you can leave review comments
here. Alternatively you can open issues on the repository for this
submission <https://github.com/csu-hmc/opty> and refer to the issues here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#300 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADHrne5AZD4AGdJBtHsiEZhrEGs69enDks5saOjOgaJpZM4OAG_o>
.
|
|
|
@whedon generate pdf |
|
|
|
@whedon generate pdf |
|
|
|
@whedon generate pdf |
|
|
|
@whedon generate pdf |
|
|
|
The table fits now. It isn't perfect but it is too difficult to try to fine tune it via markdown and limited control of the LaTeX source. We can go with this. |
|
OK thanks @moorepants. @Kevin-Mattheus-Moerman - is this submission good to accept now? The checklist at the top of the review isn't filled but it sounds like we might be done based on other comments in the thread. |
|
Looks great!. I went through the checklist and checked all the boxes.
…On Tue, Jan 30, 2018 at 5:35 AM, Arfon Smith ***@***.***> wrote:
OK thanks @moorepants <https://github.com/moorepants>.
@Kevin-Mattheus-Moerman <https://github.com/kevin-mattheus-moerman> - is
this submission good to accept now? The checklist at the top of the review
isn't filled but it sounds like we might be done based on other comments in
the thread.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#300 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE9qqzBsTZMHPZYkYLOeqtycF4MDOfwuks5tPv6HgaJpZM4OAG_o>
.
|
|
@moorepants can you provide a DOI of the reviewed software (e.g. through Zenodo)? Then @arfon can proceed to formally accept this submission. |
|
I will package a new release of the software, push to PyPi, conda, and then Zenodo for archival purposes. Note that the version number will go up. Do we not need to get @jslee02 @cybanical and @demotu's final approval? I addressed comments from all of them in the new version. |
|
I've pushed version 1.0.0 to Zenodo: DOI: 10.5281/zenodo.1162870 |
|
@whedon set 10.5281/zenodo.1162870 as archive |
|
OK. 10.5281/zenodo.1162870 is the archive. |
|
@stavness @demotu - many thanks for your reviews here and to @Kevin-Mattheus-Moerman for editing this submission ✨ @moorepants - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00300 ⚡️ 🚀 💥 |
|
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippet: This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider volunteering to review for us sometime in the future. You can add your name to the reviewer list here: http://joss.theoj.org/reviewer-signup.html |
|
Thanks everyone. I appreciate the time and effort spent on reviewing this. |
whedon
added
published
Submitting author: @moorepants (Jason K. Moore)
Repository: https://github.com/csu-hmc/opty
Version: v0.2.0
Editor: @Kevin-Mattheus-Moerman
Reviewer: @stavness
Archive: 10.5281/zenodo.1162870
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer questions
@cybanical, please carry out your review in this issue by updating the checklist below (please make sure you're logged in to GitHub). The reviewer guidelines are available here: http://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @Kevin-Mattheus-Moerman know.
Conflict of interest
General checks
Functionality
Documentation
Software paper
paper.mdfile include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: