Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Opyrability: A Python package for process operability analysis #5909

Closed
editorialbot opened this issue Oct 1, 2023 · 30 comments
Assignees
Labels

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Oct 1, 2023

Submitting author: @victoraalves (Victor Alves)
Repository: https://github.com/CODES-group/opyrability
Branch with paper.md (empty if default branch):
Version: v1.4.3
Editor: @kyleniemeyer
Reviewers: @gmxavier, @mustafaalsalmi1999
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c777df5bfaf8c950d7e118185e987491"><img src="https://joss.theoj.org/papers/c777df5bfaf8c950d7e118185e987491/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c777df5bfaf8c950d7e118185e987491/status.svg)](https://joss.theoj.org/papers/c777df5bfaf8c950d7e118185e987491)

Author instructions

Thanks for submitting your paper to JOSS @victoraalves. Currently, there isn't a JOSS editor assigned to your paper.

@victoraalves if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Oct 1, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.18 s (818.8 files/s, 285192.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            20           3357             78           9771
JavaScript                      19           2497           2599           9653
CSS                             12            811            115           2904
PO File                         45           1007              0           2284
Python                           9            855            706           1887
Jupyter Notebook                18              0           9631           1056
TeX                              2            116              2            881
SVG                              6              2             34            696
Markdown                         6            229              0            630
reStructuredText                 4            150            109            243
YAML                             9             36             30            188
TOML                             1              3              0             36
-------------------------------------------------------------------------------
SUM:                           151           9063          13304          30229
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1439

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1021/acs.iecr.8b04337 is OK
- 10.1021/acs.iecr.9b05181 is OK
- 10.1002/aic.15439 is OK
- 10.1021/acs.iecr.8b05482 is OK
- 10.1021/ie1009316 is OK
- 10.1016/j.compchemeng.2020.106979 is OK
- 10.1016/S0967-0661(02)00217-4 is OK
- 10.1002/aic.11579 is OK
- 10.1016/S0959-1524(99)00045-1 is OK
- 10.1021/ie0490076 is OK
- 10.1021/jp506259k is OK
- 10.1002/aic.16113 is OK
- 10.1016/j.compchemeng.2011.06.005 is OK
- 10.1002/aic.11228 is OK
- 10.1007/s12247-010-9086-y is OK
- 10.1016/j.jprocont.2010.04.008 is OK
- 10.2514/1.6386 is OK
- 10.1016/B978-0-444-64241-7.50390-6 is OK
- 10.1002/aic.12021 is OK
- 10.1021/ie0109814 is OK
- 10.1002/aic.18119 is OK
- 10.1007/s10107-004-0559-y is OK
- 10.1016/j.compchemeng.2022.107835 is OK

MISSING DOIs

- 10.1115/1.4018788 may be a valid DOI for title: Process lags in automatic-control circuits

INVALID DOIs

- https://doi.org/10.1016/j.ifacol.2015.09.055 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.compchemeng.2016.12.010 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/B978-0-444-63578-5.50025-6 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

OpenOA: An Open-Source Codebase For Operational Analysis of Wind Farms
Submitting author: @jordanperr
Handling editor: @sjpfenninger (Retired)
Reviewers: @gschivley, @brynpickering
Similarity score: 0.8014

opty: Software for trajectory optimization and parameter identification using direct collocation
Submitting author: @moorepants
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @stavness
Similarity score: 0.8012

ddop: A python package for data-driven operations management
Submitting author: @AndreasPhilippi
Handling editor: @arfon (Active)
Reviewers: @kramea, @g4brielvs
Similarity score: 0.8005

Linopy: Linear optimization with n-dimensional labeled variables
Submitting author: @fabianhofmann
Handling editor: @Fei-Tao (Active)
Reviewers: @torressa, @g4brielvs
Similarity score: 0.8002

TESPy: Thermal Engineering Systems in Python
Submitting author: @fwitte
Handling editor: @kyleniemeyer (Active)
Reviewers: @arosen93, @corentin-dev
Similarity score: 0.8002

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

@kyleniemeyer
Copy link

Hi @victoraalves, I'm going to edit your submission. Any reviewer suggestions you have would be welcome!

Also, please take a look at those DOI messages for your paper.

@kyleniemeyer
Copy link

@editorialbot assign @kyleniemeyer as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @kyleniemeyer is now the editor

@kyleniemeyer
Copy link

Hi @AndreasPhilippi, this package has some relevance to your published JOSS article from a few years ago. Could you help us by reviewing this submission?

@kyleniemeyer
Copy link

Hello @kramea, would you be able to review this submission to JOSS?

@victoraalves
Copy link

Hi @victoraalves, I'm going to edit your submission. Any reviewer suggestions you have would be welcome!

Also, please take a look at those DOI messages for your paper.

Hi @kyleniemeyer thank you! I have fixed the invalid/missing DOIs mentioned by the editorialbot. For now I agree with your suggestions for reviewers.

@victoraalves
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @victoraalves, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@victoraalves
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1021/acs.iecr.8b04337 is OK
- 10.1016/j.ifacol.2015.09.055 is OK
- 10.1021/acs.iecr.9b05181 is OK
- 10.1002/aic.15439 is OK
- 10.1021/acs.iecr.8b05482 is OK
- 10.1021/ie1009316 is OK
- 10.1016/j.compchemeng.2016.12.010 is OK
- 10.1016/B978-0-444-63578-5.50025-6 is OK
- 10.1016/j.compchemeng.2020.106979 is OK
- 10.1016/S0967-0661(02)00217-4 is OK
- 10.1002/aic.11579 is OK
- 10.1016/S0959-1524(99)00045-1 is OK
- 10.1021/ie0490076 is OK
- 10.1021/jp506259k is OK
- 10.1002/aic.16113 is OK
- 10.1016/j.compchemeng.2011.06.005 is OK
- 10.1002/aic.11228 is OK
- 10.1007/s12247-010-9086-y is OK
- 10.1016/j.jprocont.2010.04.008 is OK
- 10.2514/1.6386 is OK
- 10.1016/B978-0-444-64241-7.50390-6 is OK
- 10.1002/aic.12021 is OK
- 10.1115/1.4018788 is OK
- 10.1021/ie0109814 is OK
- 10.1002/aic.18119 is OK
- 10.1007/s10107-004-0559-y is OK
- 10.1016/j.compchemeng.2022.107835 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@victoraalves
Copy link

@kyleniemeyer Based on the JOSS list, some other reviewers can be, in case the others don't respond: Gilberto M. Xavier, Andy Shahidehpour, Mark E Fuller. I focused my search on people related to Chemical Engineering & Python development. Needless to say I declare no COIs. I don't know any of these people.

@kyleniemeyer
Copy link

Hello @gmxavier, are you able to review this submission for JOSS?

@kyleniemeyer
Copy link

Hello @mefuller, are you able to review this submission for JOSS?

@gmxavier
Copy link

gmxavier commented Oct 11, 2023 via email

@mefuller
Copy link

mefuller commented Oct 11, 2023

Hello @mefuller, are you able to review this submission for JOSS?

Hi, sorry, I cannot commit at this time @kyleniemeyer

@kyleniemeyer
Copy link

Thanks @gmxavier! We have reviewer guidelines written up you can look through. Briefly, once we find a second reviewer, I will start a separate review issue, where you will generate a checklist of items to work through.

You'll need to download and install the software, and inspect the repository
and submitted paper for key elements. Any feedback you have for the authors can be given as a comment in the review issue, or as an issue at the package's repository.

@kyleniemeyer
Copy link

@editorialbot add @gmxavier as reviewer

@editorialbot
Copy link
Collaborator Author

@gmxavier added to the reviewers list!

@kyleniemeyer
Copy link

Hello @mustafaalsalmi1999, are you available to edit this submission to JOSS?

@mustafaalsalmi1999
Copy link

Yes, I am happy to help.

@kyleniemeyer
Copy link

@editorialbot add @mustafaalsalmi1999 as reviewer

Thanks @mustafaalsalmi1999!

@editorialbot
Copy link
Collaborator Author

@mustafaalsalmi1999 added to the reviewers list!

@kyleniemeyer
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5966.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants