Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: pd-parser: A tool for Matching Photodiode Deflection Events to Time-Stamped Events #2650

Closed
whedon opened this issue Sep 8, 2020 · 49 comments

Comments

@whedon
Copy link

whedon commented Sep 8, 2020

Submitting author: @alexrockhill (Alexander Rockhill)
Repository: https://github.com/alexrockhill/pd-parser
Version: 0.1
Editor: @oliviaguest
Reviewers: @rougier, @rly, @libertyh
Managing EiC: Daniel S. Katz

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @alexrockhill. Currently, there isn't an JOSS editor assigned to your paper.

@alexrockhill if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Sep 8, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Sep 8, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=1.08 s (120.8 files/s, 45416.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSS                             44           1233            409          14704
JavaScript                      17           3447           2895          11572
HTML                            29           1014             29           7532
RobotFramework                   3              0              0           1771
Python                          10            184            475           1312
reStructuredText                17            541            441            407
SVG                              1              0              0            288
TeX                              1              6              0            259
XML                              1             31              0            151
YAML                             2              9              4             91
make                             2             24              9             59
Markdown                         1             13              0             37
DOS Batch                        1              8              1             26
Jupyter Notebook                 2              0            276             12
-------------------------------------------------------------------------------
SUM:                           131           6510           4539          38221
-------------------------------------------------------------------------------


Statistical information for the repository '2650' was gathered on 2020/09/08.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Alex                            41         37869            729           98.29
Alex Rockhill                    3           508            164            1.71

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Alex                      38275          101.1          0.6               16.36

@whedon
Copy link
Author

whedon commented Sep 8, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/sdata.2016.44 is OK
- 10.3389/fnins.2013.00267 is OK
- 10.1038/sdata.2018.110 is OK
- 10.1038/s41597-019-0104-8 is OK
- 10.1038/s41597-019-0105-7 is OK
- 10.21105/joss.01896 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Sep 8, 2020

@danielskatz
Copy link

👋 @alexrockhill - please add something to the README that explains how this is research software. What kinds of researchers need this software? (this is in the paper)

Also, note that some images in the README seem broken

@danielskatz
Copy link

👋 @oliviaguest - would you be willing to edit this submission?

@danielskatz
Copy link

@whedon invite @oliviaguest as editor

@whedon
Copy link
Author

whedon commented Sep 8, 2020

@oliviaguest has been invited to edit this submission.

@oliviaguest
Copy link
Member

@danielskatz sure. 😊

@oliviaguest
Copy link
Member

@whedon assign @oliviaguest as editor

@whedon
Copy link
Author

whedon commented Sep 10, 2020

OK, the editor is @oliviaguest

@oliviaguest
Copy link
Member

@alexrockhill if you can drop some names for potential reviewers when you get a chance that would be super useful.

@oliviaguest
Copy link
Member

@whedon add @rougier as reviewer

@whedon whedon assigned oliviaguest and rougier and unassigned oliviaguest Sep 10, 2020
@whedon
Copy link
Author

whedon commented Sep 10, 2020

OK, @rougier is now a reviewer

@alexrockhill
Copy link

@alexrockhill if you can drop some names for potential reviewers when you get a chance that would be super useful.

Maybe @TomDonoghue has time now that he's finished his PhD (congratulations by the way!) or @sappelhoff?

@sappelhoff
Copy link
Member

According to the JOSS conflict of interest policy I'd have such a conflict for reviewing this piece, because I am working with Alex on mne-bids, which we published a paper on in 2019.

I think I could still make a relatively impartial judgment (this is up to @oliviaguest to decide) ... but if we can find another reviewer that'd be good as well.

@oliviaguest
Copy link
Member

@sappelhoff Fine with me, yup.

@oliviaguest
Copy link
Member

@whedon add @sappelhoff as reviewer

@whedon whedon assigned oliviaguest and rougier and unassigned rougier and oliviaguest Sep 11, 2020
@oliviaguest
Copy link
Member

OK, cool! @libertyh do you want to review this given the above (no conflict from JOSS' perspective)?

@sneakers-the-rat
Copy link

re: COI, Alex and I are both at University of Oregon (though I believe in different departments), I've done some light troubleshooting of a server with him but haven't collaborated on any major work. I think I can be impartial but also know that doesn't quite work for COI.

let me know if that is ok for JOSS

@oliviaguest
Copy link
Member

@danielskatz I think that's borderline but not a COI? Assuming I mean reading the documentation properly?

@danielskatz
Copy link

Well

In addition, your recent (past year) association with the same organization of a submitter is a COI, for example, being employed at the same institution.

So this is a conflict for that reason. Again, if we can find a reviewer without conflicts, that would be better. If not, I think this is ok.

@oliviaguest
Copy link
Member

Damn! This is so COI-y. OK, I'll try my best.

@oliviaguest
Copy link
Member

@whedon remove @sneakers-the-rat as reviewer

@whedon whedon assigned oliviaguest and rougier and unassigned rougier and oliviaguest Sep 11, 2020
@whedon
Copy link
Author

whedon commented Sep 11, 2020

OK, @sneakers-the-rat is no longer a reviewer

@oliviaguest
Copy link
Member

@whedon add @rly as reviewer

@whedon whedon assigned oliviaguest and rougier and unassigned rougier and oliviaguest Sep 15, 2020
@whedon
Copy link
Author

whedon commented Sep 15, 2020

OK, @rly is now a reviewer

@oliviaguest
Copy link
Member

@whedon start review

@whedon
Copy link
Author

whedon commented Sep 15, 2020

OK, I've started the review over in #2674.

@whedon whedon closed this as completed Sep 15, 2020
@libertyh
Copy link

libertyh commented Sep 15, 2020 via email

@oliviaguest
Copy link
Member

@whedon add @libertyh as reviewer

@whedon
Copy link
Author

whedon commented Sep 15, 2020

OK, @libertyh is now a reviewer

@oliviaguest
Copy link
Member

@libertyh awesome — thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants