Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: containerit: Generating Dockerfiles for reproducible research with R #1595

Closed
whedon opened this issue Jul 25, 2019 · 39 comments
Closed
Assignees
Labels
pre-review R rOpenSci Submissions associated with rOpenSci Shell TeX

Comments

@whedon
Copy link

whedon commented Jul 25, 2019

Submitting author: @nuest (Daniel Nüst)
Repository: https://github.com/o2r-project/containerit/
Version: v0.5.0
Editor: @terrytangyuan
Reviewers: @vsoch

Author instructions

Thanks for submitting your paper to JOSS @nuest. Currently, there isn't an JOSS editor assigned to your paper.

@nuest if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jul 25, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Jul 25, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jul 25, 2019

Failed to discover a valid open source license.

@whedon whedon added the TeX label Jul 25, 2019
@whedon
Copy link
Author

whedon commented Jul 25, 2019

PDF failed to compile for issue #1595 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon.rb:115:in check_fields': Paper YAML header is missing expected fields: authors (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon.rb:80:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon/processor.rb:36:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon/processor.rb:36:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/bin/whedon:55:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@kyleniemeyer
Copy link

Hi @nuest, while we get started handling this submission, please merge the PR I submitted, which fixes the authors field in the paper: o2r-project/containerit#152

@kyleniemeyer
Copy link

@arfon whedon didn't find a license, but I can see the GPL-3.0 license in the repository: https://github.com/o2r-project/containerit/blob/master/LICENSE

Any ideas? Just ignore?

@kyleniemeyer
Copy link

@lheagy @kthyng can one of you edit this submission? I realize it's a bit outside your domain, but others are a bit overloaded and Karthik (who I'd normally ship R stuff to) is away for a bit.

@arfon
Copy link
Member

arfon commented Jul 26, 2019

@arfon whedon didn't find a license, but I can see the GPL-3.0 license in the repository: https://github.com/o2r-project/containerit/blob/master/LICENSE

Any ideas? Just ignore?

Weird, I think this can be safely ignored.

@nuest
Copy link

nuest commented Jul 26, 2019

Hi! Thanks for getting things going, and for fixing the error in the paper.md rightaway.

@nuest
Copy link

nuest commented Jul 26, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jul 26, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jul 26, 2019

@nuest
Copy link

nuest commented Jul 26, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jul 26, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jul 26, 2019

@nuest
Copy link

nuest commented Jul 26, 2019

PDF generation works, and I added some manual breaks in the contained code snippet so the line does not run off the page:

image

Now:

image

@nuest
Copy link

nuest commented Jul 26, 2019

Suggested reviewers from the JOSS list:

@vsoch
Copy link

vsoch commented Jul 26, 2019

Yes!

@cole-brokamp
Copy link

I'm currently reviewing a singularity compose manuscript by @vsoch but I can't turn this one down either! I would love to review as well if I can!

@kyleniemeyer
Copy link

Thanks @vsoch and @cole-brokamp! We're still waiting to get an editor assigned, but I will definitely take you up on the offers to review. @cole-brokamp you can certainly wait until you have completed your other review.

@adamhsparks
Copy link

adamhsparks commented Jul 27, 2019 via email

@nuest
Copy link

nuest commented Jul 27, 2019

Thank you @vsoch @cole-brokamp ! I look forward to your feedback.

@terrytangyuan
Copy link
Member

@kyleniemeyer I can definitely help with this one as I am wrapping up with one of the other edits. Feel free to assign me if you cannot find anyone else.

@kyleniemeyer
Copy link

@terrytangyuan sure, if you're willing to take it!

@kyleniemeyer
Copy link

@whedon assign @terrytangyuan as editor

@whedon
Copy link
Author

whedon commented Jul 28, 2019

OK, the editor is @terrytangyuan

@kyleniemeyer
Copy link

@whedon assign @vsoch @cole-brokamp as reviewer

@whedon
Copy link
Author

whedon commented Jul 28, 2019

OK, the reviewer is @vsoch @cole-brokamp

@terrytangyuan
Copy link
Member

terrytangyuan commented Jul 28, 2019

@whedon assign @cole-brokamp as reviewer

@whedon
Copy link
Author

whedon commented Jul 28, 2019

OK, the reviewer is @cole-brokamp

@terrytangyuan
Copy link
Member

@whedon assign @vsoch as reviewer

@whedon
Copy link
Author

whedon commented Jul 28, 2019

OK, the reviewer is @vsoch

@terrytangyuan
Copy link
Member

@whedon start review

@whedon
Copy link
Author

whedon commented Jul 28, 2019

OK, I've started the review over in #1603. Feel free to close this issue now!

@danielskatz
Copy link

danielskatz commented Jul 28, 2019

👋 @terrytangyuan - you need to
@whedon assign X as reviewer -- for the first reviewer
@whedon add Y as reviewer -- for additional reviewers

otherwise, only the last assign is stored

@terrytangyuan
Copy link
Member

@danielskatz Thanks for the tip! I was wondering why it didn't work and then manually edited the description in the review issue. I'll do that next time.

@danielskatz
Copy link

I opened openjournals/whedon-api#63 for this - feel free to make more suggestions as to how this should better work

@lheagy
Copy link
Member

lheagy commented Jul 29, 2019

Sorry for my late reply, I just returned from 4 days of backpacking and am getting caught up. If you are still in need of an editor here, I am happy to jump in and help, otherwise, @terrytangyuan it looks like you have things in motion!

@kthyng
Copy link

kthyng commented Aug 2, 2019

Ah, I'm sorry too — I'm traveling and looking through email but missing some things.

@arfon arfon added the rOpenSci Submissions associated with rOpenSci label Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review R rOpenSci Submissions associated with rOpenSci Shell TeX
Projects
None yet
Development

No branches or pull requests