Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Virtual Scanner: MRI on a Browser #1590

Closed
whedon opened this issue Jul 23, 2019 · 39 comments
Closed

[PRE REVIEW]: Virtual Scanner: MRI on a Browser #1590

whedon opened this issue Jul 23, 2019 · 39 comments

Comments

@whedon
Copy link

whedon commented Jul 23, 2019

Submitting author: @imr-framework (Sairam Geethanath)
Repository: https://github.com/imr-framework/virtual-scanner
Version: 1.0.0
Editor: @arokem
Reviewers: @nstikov, @vsoch

Author instructions

Thanks for submitting your paper to JOSS @imr-framework. Currently, there isn't an JOSS editor assigned to your paper.

@imr-framework if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jul 23, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Jul 23, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jul 23, 2019

PDF failed to compile for issue #1590 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/1590 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in collect!'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon/processor.rb:61:in find_paper_paths'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@sairamgeethanath
Copy link

@whedon commands

@whedon
Copy link
Author

whedon commented Jul 23, 2019

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

@sairamgeethanath
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jul 23, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jul 23, 2019

@kyleniemeyer
Copy link

Hi @sairamgeethanath, thanks for your submission to JOSS! I'm about to assign an editor to handle your submission, but first:

JOSS only considers software with a clear research application. Your submission looks interesting, but the paper and documentation seem to focus more on educational/training applications. We think your tool does in fact have research applications, but they aren't currently clear. Can you revise your paper to discuss this more?

@kyleniemeyer
Copy link

@whedon assign @arokem as editor

@whedon
Copy link
Author

whedon commented Jul 23, 2019

OK, the editor is @arokem

@arokem
Copy link

arokem commented Jul 24, 2019

👋 @TheChymera : would you be willing to review this paper for JOSS?

@arokem
Copy link

arokem commented Jul 26, 2019

@TheChymera : would you be willing to review this submission for JOSS?

@sairamgeethanath
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jul 26, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jul 26, 2019

@TheChymera
Copy link

@arokem thank you for your consideration.

As a developer, I am not at all familiar with web applications, and as a user I have always found them unwieldy to integrate into other workflows. It is entirely possible that given this design choice by the authors, my review will be both slower and more critical, than if it were coming from someone who can actually compare the application to what can be expected of web apps in general.

I would encourage you to ask other potential reviewers, including @damaggu . If none other can be found, I could try looking into this no earlier than late August.

@arokem
Copy link

arokem commented Jul 27, 2019

Thanks @TheChymera : let's see if I can't find someone to get on this earlier.

@arokem
Copy link

arokem commented Jul 27, 2019

@imr-framework : do you have any suggestions from the list of potential reviewers?

@arokem
Copy link

arokem commented Jul 27, 2019

👋 @pgadige: would you be willing to review this paper for JOSS? Your expertise in web applications should come in handy.

👋 @vsoch : would you be willing to review this paper for JOSS? Your unique combination of knowledge about web technologies and MRI makes you uniquely qualified.

@vsoch
Copy link

vsoch commented Jul 27, 2019

I can't say no after that! :)

I'd be happy to, I'm also about to review #1595 so please keep that in mind. I'm not sure that @imr-framework would want me to, however, because I don't see any reproducible containers or tests and these would be required (on top of the normal boxes we check off) to give a thumbs up for publication.

@arokem
Copy link

arokem commented Jul 28, 2019

Great. Thanks!

@arokem
Copy link

arokem commented Jul 28, 2019

@assign vsoch as reviewer

@arokem
Copy link

arokem commented Jul 28, 2019

Let's see if I can't get on more reviewer before kicking off the review

@arokem
Copy link

arokem commented Jul 31, 2019

👋 @spinicist : would you be willing to review this paper for JOSS? Your expertise in MRI will be useful here.

@spinicist
Copy link

Hello, what's the time frame on this? I will be on leave soon and am unlikely to get to it before I go, so there could be a substantial delay in my input. If that's acceptable I'm very happy to review.

@arokem
Copy link

arokem commented Aug 1, 2019

Hi @spinicist : thanks. How substantial is substantial (when do you think that you will be able to get to it)?

@spinicist
Copy link

Realistically, early September.

@arokem
Copy link

arokem commented Aug 1, 2019

Thanks! Let me see if I can get someone else who would be willing to give this a look earlier than that.

@arokem
Copy link

arokem commented Aug 9, 2019

I am having difficulties finding another reviewer for this paper.

@imr-framework : do you have any suggestions for potential reviewers?

@sairamgeethanath
Copy link

sairamgeethanath commented Aug 9, 2019 via email

@arokem
Copy link

arokem commented Aug 9, 2019

OK. I contacted @nstikov who has agreed to do the review in tandem with @mathieuboudreau.

I'll add @nstikov to the review and launch the review forum and @mathieuboudreau is welcome to chime in there or on the project issues as well.

@arokem
Copy link

arokem commented Aug 9, 2019

@whedon assign @nstikov as reviewer

@whedon
Copy link
Author

whedon commented Aug 9, 2019

OK, the reviewer is @nstikov

@arokem
Copy link

arokem commented Aug 9, 2019

@whedon add @vsoch as reviewer

@whedon whedon assigned arokem and vsoch and unassigned arokem Aug 9, 2019
@whedon
Copy link
Author

whedon commented Aug 9, 2019

OK, @vsoch is now a reviewer

@arokem
Copy link

arokem commented Aug 9, 2019

@whedon start review

@whedon
Copy link
Author

whedon commented Aug 9, 2019

OK, I've started the review over in #1637. Feel free to close this issue now!

@arokem
Copy link

arokem commented Aug 9, 2019

OK - @vsoch, @nstikov and @mathieuboudreau, please head over to #1637 for your review checklists and for the up-to-date pdf of the manuscript. Let me know if you have any questions. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants