Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: TEAM: Tensegrity Engineering Analysis Master #1507

Closed
whedon opened this issue Jun 16, 2019 · 41 comments
Closed

[PRE REVIEW]: TEAM: Tensegrity Engineering Analysis Master #1507

whedon opened this issue Jun 16, 2019 · 41 comments

Comments

@whedon
Copy link

whedon commented Jun 16, 2019

Submitting author: @ramaniitrgoyal92 (Raman Goyal)
Repository: https://github.com/ramaniitrgoyal92/Tensegrity_Engineering_Analysis_Master-TEAM-
Version: v2.1
Editor: @Kevin-Mattheus-Moerman
Reviewers: @apsabelhaus, @vaishnavtv, @ctdegroot

Author instructions

Thanks for submitting your paper to JOSS @ramaniitrgoyal92. Currently, there isn't an JOSS editor assigned to your paper.

@ramaniitrgoyal92 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jun 16, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Jun 16, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jun 16, 2019

PDF failed to compile for issue #1507 with the following error:

Can't find any papers to compile :-(

@arfon
Copy link
Member

arfon commented Jun 16, 2019

Hi @ramaniitrgoyal92, thanks for your submission to JOSS. Please rename your paper to paper.md

@ramaniitrgoyal92
Copy link

Submitting author: @ramaniitrgoyal92 (Raman Goyal)
Repository: https://github.com/ramaniitrgoyal92/Tensegrity_Engineering_Analysis_Master-TEAM-
Version: v2.1
Editor: Pending
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @ramaniitrgoyal92. Currently, there isn't an JOSS editor assigned to your paper.

@ramaniitrgoyal92 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
`

The suggested reviewers:

@apsabelhaus
@moorepants
@ctdegroot
@vaishnavtv
@Datseris

@apsabelhaus
Copy link

For the editor, once they're assigned:
If chosen as a reviewer, I'd be happy to review this work.

However, I'd like to quickly check about JOSS' Conflict of Interest policy (https://joss.readthedocs.io/en/latest/reviewer_guidelines.html), since I'm still new to open review (not blind). The submitting author @ramaniitrgoyal92 and I are professional acquaintances who have discussed research before and compared our past publications, but have not collaborated on funded work or authorship, and are not members of the same institution. Normally this wouldn't be a problem for single-blind review, but does it pose a challenge for open review? Either way, I believe I can provide an "impartial assessment," but would like to disclose our relationship before agreeing to be a reviewer.

@Datseris
Copy link

Hello. Thank you for invitation but I do not have the expertise to review this:

  • I do not know anything about MATLAB (I actually have never seen MATLAB code)
  • I do not have the scientific expertise on the area the submitted TEAM software is tackling, which seems to be around control systems.

I will have to pass on this, sorry.

@arfon
Copy link
Member

arfon commented Jun 17, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 17, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jun 17, 2019

PDF failed to compile for issue #1507 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-18b9a37e7f54/lib/whedon/orcid_validator.rb:12:in initialize': undefined method strip' for nil:NilClass (NoMethodError)
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-18b9a37e7f54/lib/whedon.rb:123:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-18b9a37e7f54/lib/whedon.rb:123:in block in check_orcids'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-18b9a37e7f54/lib/whedon.rb:121:in each' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-18b9a37e7f54/lib/whedon.rb:121:in check_orcids'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-18b9a37e7f54/lib/whedon.rb:81:in initialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-18b9a37e7f54/lib/whedon/processor.rb:36:in new'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-18b9a37e7f54/lib/whedon/processor.rb:36:in set_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-18b9a37e7f54/bin/whedon:55:in prepare'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-18b9a37e7f54/bin/whedon:116:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @Kevin-Mattheus-Moerman as editor

@whedon
Copy link
Author

whedon commented Jun 17, 2019

OK, the editor is @Kevin-Mattheus-Moerman

@Kevin-Mattheus-Moerman
Copy link
Member

@apsabelhaus thanks for raising the conflict of interest issue. I'll add you as a reviewer but will also recruit others. Thanks

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @apsabelhaus as reviewer

@whedon
Copy link
Author

whedon commented Jun 17, 2019

OK, the reviewer is @apsabelhaus

@Kevin-Mattheus-Moerman
Copy link
Member

@vaishnavtv @ctdegroot since you were involved with #1042, would you be interested in helping with this review?

@Kevin-Mattheus-Moerman
Copy link
Member

@ramaniitrgoyal92 Please rename your paper to paper.md, this way @whedon will find it okay to render the PDF. Thanks

@ctdegroot
Copy link

@Kevin-Mattheus-Moerman Yes, I can help with this review.

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Jun 17, 2019

@apsabelhaus @ctdegroot thanks for helping with this review. We have to iron out some things with the paper and I hope to recruit an additional reviewer. I'll ping you again when we are ready to start the review process.

@vaishnavtv
Copy link

@Kevin-Mattheus-Moerman, I would love to help with the review, but under full disclosure, I'd like to state that the submitting author and I are personally acquainted and are pursuing a graduate degree from the same institution. We have not officially collaborated on any research, but our advisors have worked together in the past. If this violates any reviewer policies based on a conflict of interest, kindly let me know.

@Kevin-Mattheus-Moerman
Copy link
Member

Thanks @vaishnavtv (sorry I accidentally tagged you in the comment above I just edited) for reporting that potential conflict of interest. If you'd like to help your help is still appreciated. I will however recruit an additional reviewer.

@ramaniitrgoyal92
Copy link

@arfon @Kevin-Mattheus-Moerman Thanks for reminding! I have changed the file name.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 17, 2019

Attempting PDF compilation. Reticulating splines etc...

@ramaniitrgoyal92
Copy link

@whedon generate pdf

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 17, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jun 17, 2019

@apsabelhaus
Copy link

great, happy to be a reviewer. @ramaniitrgoyal92 I'll probably need at least three weeks to get around to this - my dissertation draft is due to my committee ASAP - so you can expect my first round of comments during mid-July. @Kevin-Mattheus-Moerman let me know when the process is ready to start and that checklist is up. 👍

@Kevin-Mattheus-Moerman
Copy link
Member

@Jfriesen222 would you be interested in reviewing this work on tensegrity modelling for JOSS? The review process will focus on the software and this short paper.

@apsabelhaus
Copy link

apsabelhaus commented Jul 26, 2019

@Kevin-Mattheus-Moerman is the review thread started for this submission yet? I'm available to start the review process, but can't seem to find the link to e.g. the checklist.

@apsabelhaus
Copy link

@ramaniitrgoyal92 while we're waiting for the official review to open, I added a first issue in the repo about organization and documentation, so there's something to start on! Also, the paper is missing references [???], probably a bug in the latex.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon add @vaishnavtv as reviewer

@whedon
Copy link
Author

whedon commented Jul 31, 2019

OK, @vaishnavtv is now a reviewer

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon add @ctdegroot as reviewer

@whedon
Copy link
Author

whedon commented Jul 31, 2019

OK, @ctdegroot is now a reviewer

@Kevin-Mattheus-Moerman
Copy link
Member

@Jfriesen222 would you be interested in reviewing this work on tensegrity modelling for JOSS? The review process will focus on the software and this short paper.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon start review

@whedon
Copy link
Author

whedon commented Jul 31, 2019

OK, I've started the review over in #1613. Feel free to close this issue now!

@Kevin-Mattheus-Moerman
Copy link
Member

The review has started over at #1613 however additional reviewers are still welcome. Contact me if interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants