Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #616 #635

Merged
merged 1 commit into from
Aug 20, 2021
Merged

fixed #616 #635

merged 1 commit into from
Aug 20, 2021

Conversation

davideschiavone
Copy link
Contributor

Fix issue #616

As this is a bug in the doc, it may lead to erros in the compiler porting as well. Thus, pinging @jeremybennett as well

@davideschiavone
Copy link
Contributor Author

hi @jeremybennett , did you have time to have a look at it?

Copy link
Contributor

@jeremybennett jeremybennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This much more needs advice from @jessicamills and the GNU tools team. In particular the work on the PULP load/store extensions has been done by @NBruschi and @EnricoTabanelli assisted by @gtagliavini

My immediate thoughts are that the work to date has been primarily on the assembler and builtins. For the assembler the semantics of the instruction don't matter, but we need to ensure that signed literals are permitted in the syntax for the assembler. For the builtins it will affect whether signed or unsigned types are used for parameters.

There may be impacts on the linker if there are any relocations impacted - for example if the index were symbolic, then potentially we need a signed rather than unsigned relocation.

I don't believe we have any committed work on GCC, where this will be more significant. However I think @NBruschi and @EnricoTabanelli have been working on this, and should comment on the impact.

I'm happy to approve, since this comment is about ensuring that those impacted in the tool chain have an opportunity to consider the implications for their existing and future work.

@davideschiavone davideschiavone merged commit 20edf83 into openhwgroup:master Aug 20, 2021
@pascalgouedo pascalgouedo added the Component:Doc For issues in the Documentation (e.g. for README.md files) label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:Doc For issues in the Documentation (e.g. for README.md files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants