Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate UNSUPPORTED_WITH kludge for VCS #2393

Merged

Conversation

MikeOpenHWGroup
Copy link
Member

This pull-request resolves an issue with #2392 that impacts VCS. It incorporates the so-called UNSUPPORTED_WITH work-around that is in use by multiple CORE-V-VERIF projects. It is ugly, but works and needs to be in place until at least the next release of VCS.

@MikeOpenHWGroup MikeOpenHWGroup added bug Something isn't working cv32e40p labels Mar 21, 2024
Copy link

@XavierAubert XavierAubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your help on this Mike

@dd-baoshan
Copy link

dd-baoshan commented Mar 22, 2024

For #2392 , I did not use this workaround. Instead, I changed with statement clause in the way that accepted in vcs.
One question - I noticed you applied the workaround but I tested on my side without this workaround and I did not get any compilation/simulation error. Just curious, is that my fix is not fully work on your side?

Copy link

@dd-baoshan dd-baoshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with these updates and I has an inquiry in my previous comment.

@MikeOpenHWGroup
Copy link
Member Author

One question - I noticed you applied the workaround but I tested on my side without this workaround and I did not get any compilation/simulation error. Just curious, is that my fix is not fully work on your side?

Interesting. What version of VCS are you using? We have VCS S-2021.09-SP1.

@dd-baoshan
Copy link

One question - I noticed you applied the workaround but I tested on my side without this workaround and I did not get any compilation/simulation error. Just curious, is that my fix is not fully work on your side?

Interesting. What version of VCS are you using? We have VCS S-2021.09-SP1.

We here are using vcs_mx "U-2023.03-SP1".

@MikeOpenHWGroup
Copy link
Member Author

We here are using vcs_mx "U-2023.03-SP1".

Thanks @dd-baoshan. I will work to obtain this version of VCS. This will take some time, so would you be willing to accept this PR in its current state? If so , let's merge it in and I will assign and Issue to myself to get the latest version of VCS.

@MikeOpenHWGroup MikeOpenHWGroup merged commit cb2cc35 into openhwgroup:cv32e40p/dev Mar 25, 2024
1 check passed
@MikeOpenHWGroup MikeOpenHWGroup deleted the cv32e40p/dev_fixvcs branch April 4, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cv32e40p
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants