-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate UNSUPPORTED_WITH kludge for VCS #2393
Incorporate UNSUPPORTED_WITH kludge for VCS #2393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for your help on this Mike
For #2392 , I did not use this workaround. Instead, I changed with statement clause in the way that accepted in vcs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with these updates and I has an inquiry in my previous comment.
Interesting. What version of VCS are you using? We have |
We here are using vcs_mx "U-2023.03-SP1". |
Thanks @dd-baoshan. I will work to obtain this version of VCS. This will take some time, so would you be willing to accept this PR in its current state? If so , let's merge it in and I will assign and Issue to myself to get the latest version of VCS. |
This pull-request resolves an issue with #2392 that impacts VCS. It incorporates the so-called
UNSUPPORTED_WITH
work-around that is in use by multiple CORE-V-VERIF projects. It is ugly, but works and needs to be in place until at least the next release of VCS.