Fencei Assert - Rewrite Property #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Pedersen <[email protected]>
Signed-off-by: Robin Pedersen <[email protected]>
Signed-off-by: Robin Pedersen <[email protected]>
Signed-off-by: Robin Pedersen <[email protected]>
Signed-off-by: Robin Pedersen <[email protected]>
Signed-off-by: Robin Pedersen <[email protected]>
silabs-robin
commented
Oct 11, 2023
Signed-off-by: Robin Pedersen <[email protected]>
silabs-hfegran
approved these changes
Oct 12, 2023
|
Looks good to me, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Depends/Builds on #2233)
This PR updates one property in
fencei_assert.A missing sim cover was the reason for the rewrite.
Incidentally, it also fixes 2 warnings in formal.
I was down several blind alleys trying to get the code elegant, so in the end I conceded to let it be unreasonably verbose.
Test status:
ci_check- Only "clic" fails, hits the cover now.