-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASSERT_OFF #2233
ASSERT_OFF #2233
Conversation
Signed-off-by: Robin Pedersen <[email protected]>
165c825
to
c9e3204
Compare
Signed-off-by: Robin Pedersen <[email protected]>
c9e3204
to
3a66c32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very tricky diff to read, but I don't see any issues. I approve of the motivation for this change, so as long as nothing breaks this is a good change.
Approving
Signed-off-by: Robin Pedersen <[email protected]>
Much easier to read this diff with the "hide whitespace" option set. |
Looks good to me, thanks @silabs-robin |
This PR makes compilation of assertions optional.
For blazing fast re-compilation and next level productivity iteration times, simply use
+define+COREV_ASSERT_OFF
(and optionally comment away the ifndef for a specific assertion set you want to work on).Compilation times (mm:ss):
Test results:
ci_check
- All pass (except "clic").I got tired of formal taking so long to recompile just for simple changes, so that is why I implemented this.
An additional bonus, is that the warnings log is much smaller, so you specifically see all warnings related to your module.
The reason for using
ifndef
is because 1) this is consistent with the way it is already done in the RTL repo, and 2) we don't want to change the hierarchy with several additional paths with generates.