-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Zulu JDK 21 installation on 64bit #1861
Conversation
Requires a native 64 bit image, running a 64 bit kernel with 32-bit OS is not sufficient. Signed-off-by: Holger Friedrich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires a native 64 bit image, running a 64 bit kernel with 32-bit OS is not sufficient.
Please add proper checks for this in the install routine to ensure it only installs when the prerequisites are met
Hi @mstormi, If the prerequisites are not met, the common error reaction is to show a message in interactive setup (good) or to install Zulu-32 in the interactive case (maybe not so well suited). WDYT? Btw: anything wrong with my change which causes the bats test to fail, or are the tests affected by something else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine then
no BATS test failing is unrelated
Thanks, Markus |
Hi Holger, would you consider adding openjdk21 as PR, too ? In short
|
Requires a native 64 bit image, running a 64 bit kernel with 32-bit OS is not sufficient.
I have been working to make OH compile an run with Java21 openhab/openhab-distro#1590. Not all of the required PRs have been merged, so we are not yet there.
This PR allows to install Java21 on x64/aarch64 systems.
Running the snapshot distro without modification is not yet possible, still waiting for the PR openhab/openhab-distro#1640
to be merged.