Support Java 21 #1640

holgerfriedrich · 2024-03-26T00:03:42Z

Allow for compiling with Java 21

Support Java 17 and 21, default compilation to Java 17 class files
Add profile "j21" to compile to Java 21 class files
Upgrade SAT to 0.16.0
Adapt Karaf scpipts to allow both Java 17 and 21

Refs:
#1590
openhab/openhab-core#4161
openhab/openhab-addons#16594

* Support Java 17 and 21, default compilation to Java 17 class files * Add profile "j21" to compile to Java 21 class files * Upgrade SAT to 0.16.0 * Adapt Karaf scpipts to allow both Java 17 and 21 Signed-off-by: Holger Friedrich <[email protected]>

wborn

LGTM! Do you know of any other known issues besides openhab/openhab-addons#16591?

holgerfriedrich · 2024-04-01T12:29:01Z

LGTM! Do you know of any other known issues besides openhab/openhab-addons#16591?

I am not aware of other issues.
Though, I have not tested installing add-ons yet.

Need to migrate my test server to Java 21...

holgerfriedrich · 2024-04-02T19:32:04Z

Proceeding....

Modified snapshot running on RPI5, openhabian bookworm, 64bit with Zulu Java 21:

Java classes are compiled for java17, as this is the official snapshot.

Adding the KNX binding compiled with -Pj21 works fine.

holgerfriedrich · 2024-04-03T05:39:17Z

@wborn did you intentionally delay the merge of this one? You already added it to the 4.2 milestone...

Avoid ZipException with ejc >3.30.0. Signed-off-by: Holger Friedrich <[email protected]>

holgerfriedrich · 2024-04-03T19:39:16Z

Included upgrade for maven-compiler-plugin, refs openhab/openhab-core#4167

wborn · 2024-04-04T04:17:18Z

I wanted to give it another test with Java 21 myself too before the check is removed and users start creating issues that they have issues when using Java 21. 😉

holgerfriedrich · 2024-04-04T06:24:41Z

@wborn Highly appreciated. Don't miss the -Pj21 to switch to J21 code generation.
Should I pin persistence.jpa to J17 to make it work for now? I don't think that openhab/openhab-addons#16591 gets merged soon unless we find someone to test it....

It would be good if this PR is part of M2, as it contains the modification of the karaf start scripts that need to go into the deb packages.

I am doing full builds with verify of the current main branches as well, core and webui are fine. Addons still running.

holgerfriedrich · 2024-04-05T06:39:15Z

There seems to be an issue in the Java21 core build, when output is set to 17. The native J21 build works.
see my CI builds here:
https://github.com/holgerfriedrich/openhab-core/actions
https://github.com/holgerfriedrich/openhab-addons/actions

holgerfriedrich · 2024-04-05T18:05:33Z

With the PRs mentioned above (openhab/openhab-addons#16612, openhab/openhab-addons#16615, openhab/openhab-core#4171) , everything should be fine:

see my CI builds here: 🥳
https://github.com/holgerfriedrich/openhab-core/actions
https://github.com/holgerfriedrich/openhab-addons/action
The builds include Java 17, Java 21 compiler to generate Java 17 classes, and Java 21 compiler generating Java 21 classes.

holgerfriedrich · 2024-04-05T19:12:39Z

@kaikreuzer will you trigger a new milestone build this weekend? Would be nice if this one makes it into M2....

wborn · 2024-04-06T07:10:36Z

I just gave running openHAB on Java 21 another test but there seems to be some issue with date formats when deserializing timestamps on Java 21.

These errors show up when restarting openHAB:

2024-04-06 09:05:10.272 [ERROR] [re.storage.json.internal.JsonStorage] - Couldn't deserialize value 'org.openhab.core.storage.json.internal.StorageEntry@4a2246a9'. Root cause is: Failed parsing 'Apr 6, 2024, 8:53:04 AM' as Date; at path $.sessions[0].createdTime

09:01:06.164 [ERROR] [rnal.common.AbstractInvocationHandler] - An error occurred while calling method 'QueryablePersistenceService.query()' on 'org.openhab.persistence.mapdb.internal.MapDbPersistenceService@39aca3e6': Failed parsing 'Apr 6, 2024, 8:58:09 AM' as Date; at path $.timestamp
com.google.gson.JsonSyntaxException: Failed parsing 'Apr 6, 2024, 8:58:09 AM' as Date; at path $.timestamp
	at com.google.gson.internal.bind.DateTypeAdapter.deserializeToDate(DateTypeAdapter.java:90) ~[bundleFile:?]
	at com.google.gson.internal.bind.DateTypeAdapter.read(DateTypeAdapter.java:75) ~[bundleFile:?]
	at com.google.gson.internal.bind.DateTypeAdapter.read(DateTypeAdapter.java:46) ~[bundleFile:?]
	at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.readIntoField(ReflectiveTypeAdapterFactory.java:212) ~[bundleFile:?]
	at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$FieldReflectionAdapter.readField(ReflectiveTypeAdapterFactory.java:433) ~[bundleFile:?]
	at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:393) ~[bundleFile:?]
	at com.google.gson.Gson.fromJson(Gson.java:1227) ~[bundleFile:?]
	at com.google.gson.Gson.fromJson(Gson.java:1137) ~[bundleFile:?]
	at com.google.gson.Gson.fromJson(Gson.java:1047) ~[bundleFile:?]
	at com.google.gson.Gson.fromJson(Gson.java:982) ~[bundleFile:?]
	at org.openhab.persistence.mapdb.internal.MapDbPersistenceService.deserialize(MapDbPersistenceService.java:212) ~[?:?]
	at org.openhab.persistence.mapdb.internal.MapDbPersistenceService.query(MapDbPersistenceService.java:202) ~[?:?]
	at jdk.internal.reflect.GeneratedMethodAccessor64.invoke(Unknown Source) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
	at org.openhab.core.internal.common.AbstractInvocationHandler.invokeDirect(AbstractInvocationHandler.java:147) [bundleFile:?]
	at org.openhab.core.internal.common.Invocation.call(Invocation.java:52) [bundleFile:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
	at java.lang.Thread.run(Thread.java:840) [?:?]
Caused by: java.text.ParseException: Failed to parse date ["Apr 6, 2024, 8:58:09 AM"]: Invalid number: Apr 
	at com.google.gson.internal.bind.util.ISO8601Utils.parse(ISO8601Utils.java:279) ~[bundleFile:?]
	at com.google.gson.internal.bind.DateTypeAdapter.deserializeToDate(DateTypeAdapter.java:88) ~[bundleFile:?]
	... 20 more
Caused by: java.lang.NumberFormatException: Invalid number: Apr 
	at com.google.gson.internal.bind.util.ISO8601Utils.parseInt(ISO8601Utils.java:316) ~[bundleFile:?]
	at com.google.gson.internal.bind.util.ISO8601Utils.parse(ISO8601Utils.java:133) ~[bundleFile:?]
	at com.google.gson.internal.bind.DateTypeAdapter.deserializeToDate(DateTypeAdapter.java:88) ~[bundleFile:?]
	... 20 more

holgerfriedrich · 2024-04-06T07:14:59Z

Thanks, @wborn. I will be busy the next days, so this has to wait - unless you are willing to step in here.

kaikreuzer · 2024-04-06T18:58:35Z

@kaikreuzer will you trigger a new milestone build this weekend?

Yes, planned for tomorrow. With @wborn's observations, I think there is no rush to merge this and declare Java 21 support just yet. Better do this on snapshots and make them "round" before M3.

holgerfriedrich · 2024-04-06T19:15:34Z

Yes, if there are differences in deserialization, we will likely need some time to get this final.

holgerfriedrich · 2024-04-29T15:37:58Z

@wborn As openhab/openhab-core#4174 is now closed, it could be worth a next try. MapDB should not behave as expected.

wborn

Thanks! The exceptions are gone. 👍

holgerfriedrich requested a review from a team as a code owner March 26, 2024 00:03

holgerfriedrich force-pushed the pr-java21 branch 3 times, most recently from f661b01 to 6c57b39 Compare March 31, 2024 16:53

holgerfriedrich changed the title ~~[WIP] Support Java 21~~ Support Java 21 Mar 31, 2024

Allow for compiling with Java 21

568e895

* Support Java 17 and 21, default compilation to Java 17 class files * Add profile "j21" to compile to Java 21 class files * Upgrade SAT to 0.16.0 * Adapt Karaf scpipts to allow both Java 17 and 21 Signed-off-by: Holger Friedrich <[email protected]>

holgerfriedrich force-pushed the pr-java21 branch from 6c57b39 to 568e895 Compare April 1, 2024 09:14

wborn added this to the 4.2 milestone Apr 1, 2024

wborn approved these changes Apr 1, 2024

View reviewed changes

holgerfriedrich mentioned this pull request Apr 2, 2024

add Zulu JDK 21 installation on 64bit openhab/openhabian#1861

Merged

Bump maven-compiler-plugin to 3.13.0

2974eb4

Avoid ZipException with ejc >3.30.0. Signed-off-by: Holger Friedrich <[email protected]>

holgerfriedrich mentioned this pull request Apr 4, 2024

[persistence.jpa] Pin to Java 17 openhab/openhab-addons#16612

Merged

This was referenced Apr 5, 2024

[enocean] Fix Java 21 build openhab/openhab-addons#16615

Merged

[rest] Fix Java 21 build openhab/openhab-core#4171

Merged

holgerfriedrich requested a review from wborn April 5, 2024 19:10

holgerfriedrich mentioned this pull request Apr 7, 2024

Java 21 deserialization of DateTime openhab/openhab-core#4174

Closed

wborn approved these changes May 14, 2024

View reviewed changes

wborn merged commit 11e9d6b into openhab:main May 14, 2024
3 checks passed

holgerfriedrich deleted the pr-java21 branch May 14, 2024 15:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Java 21 #1640

Support Java 21 #1640

holgerfriedrich commented Mar 26, 2024 •

edited

Loading

wborn left a comment

holgerfriedrich commented Apr 1, 2024

holgerfriedrich commented Apr 2, 2024 •

edited

Loading

holgerfriedrich commented Apr 3, 2024

holgerfriedrich commented Apr 3, 2024 •

edited

Loading

wborn commented Apr 4, 2024

holgerfriedrich commented Apr 4, 2024 •

edited

Loading

holgerfriedrich commented Apr 5, 2024

holgerfriedrich commented Apr 5, 2024 •

edited

Loading

holgerfriedrich commented Apr 5, 2024

wborn commented Apr 6, 2024

holgerfriedrich commented Apr 6, 2024

kaikreuzer commented Apr 6, 2024

holgerfriedrich commented Apr 6, 2024

holgerfriedrich commented Apr 29, 2024

wborn left a comment

Support Java 21 #1640

Support Java 21 #1640

Conversation

holgerfriedrich commented Mar 26, 2024 • edited Loading

wborn left a comment

Choose a reason for hiding this comment

holgerfriedrich commented Apr 1, 2024

holgerfriedrich commented Apr 2, 2024 • edited Loading

holgerfriedrich commented Apr 3, 2024

holgerfriedrich commented Apr 3, 2024 • edited Loading

wborn commented Apr 4, 2024

holgerfriedrich commented Apr 4, 2024 • edited Loading

holgerfriedrich commented Apr 5, 2024

holgerfriedrich commented Apr 5, 2024 • edited Loading

holgerfriedrich commented Apr 5, 2024

wborn commented Apr 6, 2024

holgerfriedrich commented Apr 6, 2024

kaikreuzer commented Apr 6, 2024

holgerfriedrich commented Apr 6, 2024

holgerfriedrich commented Apr 29, 2024

wborn left a comment

Choose a reason for hiding this comment

holgerfriedrich commented Mar 26, 2024 •

edited

Loading

holgerfriedrich commented Apr 2, 2024 •

edited

Loading

holgerfriedrich commented Apr 3, 2024 •

edited

Loading

holgerfriedrich commented Apr 4, 2024 •

edited

Loading

holgerfriedrich commented Apr 5, 2024 •

edited

Loading