Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things list: Do not listen to InboxUpdatedEvents #2942

Merged

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Dec 22, 2024

Fixes #2395.
Supersedes #2918.

Those do not change the inbox count and hence can be ignored.

Those do not change the inbox count and hence can be ignored.

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 requested a review from ghys as a code owner December 22, 2024 16:33
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Dec 22, 2024
@florian-h05 florian-h05 added this to the 5.0 milestone Dec 22, 2024
Copy link

relativeci bot commented Dec 22, 2024

#2590 Bundle Size — 10.9MiB (~+0.01%).

b378c18(current) vs 8d8e46a main#2589(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2590
     Baseline
#2589
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 577.39KiB 577.39KiB
Change  Cache Invalidation 18.15% 24.27%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2946 2946
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2590
     Baseline
#2589
Regression  JS 9.11MiB (~+0.01%) 9.11MiB
No change  CSS 866.47KiB 866.47KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:inbox-count-ignore-u...Project dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 merged commit 3861fa8 into openhab:main Dec 22, 2024
6 checks passed
@florian-h05 florian-h05 deleted the inbox-count-ignore-update-event branch December 22, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MainUI] Excessive fetching of inbox rest resource from settings/things
1 participant