[MainUI] Do not reload inbox for inboxupdatedevents #2918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arne Seime <[email protected]>
#2563 Bundle Size — 10.9MiB (~+0.01%).289a5d9(current) vs c2ae0ab main#2562(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #2563 |
Baseline #2562 |
|
|---|---|---|
 Initial JS |
1.92MiB |
1.92MiB |
| Initial CSS |
577.83KiB |
577.83KiB |
 Cache Invalidation |
18.3% |
17.65% |
| Chunks |
226 |
226 |
| Assets |
249 |
249 |
| Modules |
2947 |
2947 |
| Duplicate Modules |
152 |
152 |
| Duplicate Code |
1.8% |
1.8% |
| Packages |
96 |
96 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 1 change 
1 regression
| Current #2563 |
Baseline #2562 |
|
|---|---|---|
| JS |
9.11MiB (~+0.01%) |
9.11MiB |
| CSS |
866.74KiB |
866.74KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.38KiB |
1.38KiB |
| Other |
871B |
871B |
Bundle analysis report Branch seime:thing_list_inbox_reloading Project dashboard
Generated by RelativeCI Documentation Report issue
Signed-off-by: Arne Seime <[email protected]>
seime
force-pushed
the
thing_list_inbox_reloading
branch
from
54d8a4f to
049ecb8
Compare
florian-h05
reviewed
Dec 22, 2024
There was a problem hiding this comment.
Thanks for putting this up!
Instead of ignoring the InboxUpdatedEvent client side, we can say we don't want to listen to it and the server will not sent it anymore.
I have done that in #2942, which therefore replaces this PR.
|
Superseded by #2942. |
florian-h05
added a commit
that referenced
this pull request
Dec 22, 2024
Fixes #2395. Supersedes #2918. Those do not change the inbox count and hence can be ignored. Signed-off-by: Florian Hotze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2395
Skip inboxupdatedevents as they do not change the inbox count (which is the only information actually used after loading this potentially very large structure of data)