Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule/script: Fix fields not editable in create mode or for Blockly #2318

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Rule/script: Fix fields not editable in create mode or for Blockly #2318

merged 3 commits into from
Feb 7, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 7, 2024

Regression from #2276 which caused a new rule unable to be created because the rule name/description couldn't be entered (fields are disabled)

@jimtng jimtng requested a review from a team as a code owner February 7, 2024 05:23
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 7, 2024 •
edited
Loading

Job #1448: Bundle Size — 11MiB (~+0.01%).

3556aea(current) vs 1d5d217 main#1428(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Improvement 1 improvement
                 Current
Job #1448		      Baseline
Job #1428
Improvement  Initial JS 1.84MiB(~-0.01%) 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
No change  Cache Invalidation 16.98% 16.98%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3074 3074
No change  Duplicate Modules 159 159
No change  Duplicate Code 1.74% 1.74%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1448		      Baseline
Job #1428
Regression  JS 9.19MiB (~+0.01%) 9.19MiB
Not changed  CSS 888.86KiB 888.86KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1448 report View jimtng:rule-settings-editable branch activity View project dashboard

@jimtng jimtng force-pushed the rule-settings-editable branch from e85de81 to 439245b Compare February 7, 2024 10:58
florian-h05
florian-h05 reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

I wonder how no one noticed that regression before.
I have created jimtng#1 which fixes a regression in the script general settings, which has the same PR as cause.

@jimtng
Merge pull request #1 from florian-h05/script-regression
3556aea 
Fix script language not changeable for Blockly
@florian-h05 florian-h05 merged commit 362d9f3 into openhab:main Feb 7, 2024
6 checks passed
@florian-h05 florian-h05 changed the title Fix fields should be editable for a new script Rule/script: Fix fields not editable in create mode or for Blockly Feb 7, 2024
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI regression labels Feb 7, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 7, 2024
@jimtng jimtng deleted the rule-settings-editable branch February 7, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI regression
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jimtng @florian-h05