Rule/Script edit: Fix not editable not properly handled & Always show tags #2276
Conversation
… tags Signed-off-by: Florian Hotze <[email protected]>
Job #1377: Bundle Size — 15.84MiB (+0.09%).Warning Bundle contains 16 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #1377 report View florian-h05:rule-script-not-edit... branch activity View project dashboard |
|
Just to explain a bit more what the issue was: Created a rule with JSRule, which is then still displayed as a file-based rule in the UI. When opening that rule, only the code of the rule is displayed, but things like as UID, Label, Description, Tags, Script Language can still be edited For file based rules all this should not editable, but the UI has allowed editing of all fields except the UID. Even though it was editable, saving it did not have a effect (as it should be). |
There was a problem hiding this comment.
The changes are straight forward and easy to understand.
LGTM. Thanks @florian-h05 you fixed this.
…2318) Regression from #2276 which caused a new rule unable to be created because the rule name/description couldn't be entered (fields are disabled) --------- Also-by: Florian Hotze <[email protected]> Signed-off-by: Jimmy Tanagra <[email protected]>
Fixes an issue where the configuration of a script action of a file-based rule (e.g. those created using JSRule or Rule Builder of openhab-js) was shown as editable, even though the rule is not editable because it is provisioned from file.
Always show the tag input, even if there are no rule tags. This is more consistent and avoids confusion, as you can now clearly see that a rule has no tags.