Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mainui] Increase list-item-min-height to avoid scrollbar #2114

Closed
wants to merge 1 commit into from
Closed

[mainui] Increase list-item-min-height to avoid scrollbar #2114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bundles/org.openhab.ui/web/src/css/app.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ html
--f7-list-item-header-line-height 1.3
--f7-label-line-height 1.3
--f7-list-item-after-line-height 1.3
--f7-list-item-min-height 36px
Copy link
Contributor

@florian-h05 florian-h05 Oct 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm thanks. Can you then try it with this code?

Suggested change
--f7-list-item-min-height 36px
.device-macos .chrome
--f7-list-item-min-height 36px

I do not want to change the height for all desktops, but rather only the affected ones.

Copy link
Contributor Author

@jimtng jimtng Oct 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I have:

.device-desktop
  --f7-navbar-title-line-height 1.3
  --f7-navbar-subtitle-line-height 1.3
  --f7-subnavbar-title-line-height 1.3
  --f7-list-item-header-line-height 1.3
  --f7-label-line-height 1.3
  --f7-list-item-after-line-height 1.3
  .device-macos .chrome
    --f7-list-item-min-height 36px

But this didn't work.

The --f7-list-item-min-height still resolves to 32px in Chrome

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm in that case leave out .chrome and try again.

@ghys Do you know how to target only specific browsers in CSS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing .chrome doesn't work either:

.device-desktop
  --f7-navbar-title-line-height 1.3
  --f7-navbar-subtitle-line-height 1.3
  --f7-subnavbar-title-line-height 1.3
  --f7-list-item-header-line-height 1.3
  --f7-label-line-height 1.3
  --f7-list-item-after-line-height 1.3
  .device-macos
    --f7-list-item-min-height 36px

Just .chrome without .device-macos doesn't work either.


// disable all searchbar backdrops on desktop devices
.searchbar-backdrop
Expand Down