-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mainui] Increase list-item-min-height to avoid scrollbar #2114
Conversation
The default --f7-list-item-min-height was 32px which caused a vertical scrollbar to appear on desktop Signed-off-by: Jimmy Tanagra <[email protected]>
Job #1176: Bundle Size — 15.78MiB (+0.11%).Warning Bundle contains 16 duplicate packages - View duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more - View changed packages Bundle metrics (10 changes)
Bundle size by type (3 changes)
View job #1176 report View jimtng:list-item-min-height branch activity |
I cannot reproduce the linked issue on Fedora 38 with Chromium and on Windows 11 with Chrome. On which OS/Browser does the issue do you experience that issue? |
MacOS 13.5 Does not occur on Safari (i.e. it looks good on Safari) |
@@ -14,6 +14,7 @@ html | |||
--f7-list-item-header-line-height 1.3 | |||
--f7-label-line-height 1.3 | |||
--f7-list-item-after-line-height 1.3 | |||
--f7-list-item-min-height 36px |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm thanks. Can you then try it with this code?
--f7-list-item-min-height 36px | |
.device-macos .chrome | |
--f7-list-item-min-height 36px |
I do not want to change the height for all desktops, but rather only the affected ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I have:
.device-desktop
--f7-navbar-title-line-height 1.3
--f7-navbar-subtitle-line-height 1.3
--f7-subnavbar-title-line-height 1.3
--f7-list-item-header-line-height 1.3
--f7-label-line-height 1.3
--f7-list-item-after-line-height 1.3
.device-macos .chrome
--f7-list-item-min-height 36px
But this didn't work.
The --f7-list-item-min-height
still resolves to 32px
in Chrome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm in that case leave out .chrome
and try again.
@ghys Do you know how to target only specific browsers in CSS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing .chrome doesn't work either:
.device-desktop
--f7-navbar-title-line-height 1.3
--f7-navbar-subtitle-line-height 1.3
--f7-subnavbar-title-line-height 1.3
--f7-list-item-header-line-height 1.3
--f7-label-line-height 1.3
--f7-list-item-after-line-height 1.3
.device-macos
--f7-list-item-min-height 36px
Just .chrome without .device-macos doesn't work either.
Probably best to test with BrowserStack and make sure it's all okay before making such changes. |
I can not reproduce this with BrowserStack on macOS 13.5 (Ventura) & Sonoma on:
Therefore closing this PR. |
The default --f7-list-item-min-height was 32px
which caused a vertical scrollbar to appear on desktop
Resolve #2113