Remove PNG icons from the classic icon set #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docker environment is (unfortunately) kept. It can be used to compress SVG files. Conversion from SVG into PNG format has been commented in the script .convert.sh. Closes openhab#2071 Closes openhab#1768 Signed-off-by: Laurent Garnier <[email protected]>
lolodomo
added
enhancement
|
Before merging this change, I would prefer getting first answers from @stefan-hoehn regarding potential impact on our openHAB documentation. |
mueller-ma
reviewed
Sep 24, 2023
|
@Confectrician I have no clue if it has an impact. Do you? |
Signed-off-by: Laurent Garnier <[email protected]>
This was referenced Oct 8, 2023
|
@openhab/maintainers : is there any interest for this PR ? If not, I simply close it. |
|
From my POV nothing speaks against removing the PNG icons. AFAIK SVG is supported by all modern browsers. |
kaikreuzer
approved these changes
Nov 13, 2023
Closed
florian-h05
added a commit
to florian-h05/website
that referenced
this pull request
Dec 14, 2023
Fixes openhab/openhab-docs#2169. Caused by openhab/openhab-webui#2084. Signed-off-by: Florian Hotze <[email protected]>
kaikreuzer
pushed a commit
to openhab/website
that referenced
this pull request
Dec 15, 2023
* Fix classic iconset page not showing any icons Fixes openhab/openhab-docs#2169. Caused by openhab/openhab-webui#2084. Signed-off-by: Florian Hotze <[email protected]> * Update .gitignore files for generated stuff and remove thing-types.json thing-types.json does not need to be in the repo, as it is generated by the docs build. I guess it was accidentally committed in 16da0db#diff-866bea5377be53e4c1181d586cea266080b5223a9a956a12149e4e20be09765e. Signed-off-by: Florian Hotze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker environment is (unfortunately) kept. It can be used to compress SVG files. Conversion from SVG into PNG format has been commented in the script .convert.sh.
Closes #2071
Closes #1768
Signed-off-by: Laurent Garnier [email protected]