Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon "player" from classic icon set broken #1768

Closed
mueller-ma opened this issue Mar 5, 2023 · 4 comments · Fixed by #2084
Closed

Icon "player" from classic icon set broken #1768

mueller-ma opened this issue Mar 5, 2023 · 4 comments · Fixed by #2084
Labels
bug Something isn't working iconset openHAB icon collection

Comments

@mueller-ma
Copy link
Member

The problem

The text "Power on" from the SVG version of the icon "player" is broken in the PNG version:

Expected behavior

Both should look the same.

Steps to reproduce

  1. Open the links above.
@mueller-ma mueller-ma added the bug Something isn't working label Mar 5, 2023
@lolodomo
Copy link
Contributor

lolodomo commented Mar 6, 2023

We have the convert script (convert, sh) that converts all SVG in PNG. You could check if it fixes the player icon.

@lolodomo
Copy link
Contributor

lolodomo commented Mar 6, 2023

The .convert.sh script requires a Linux environment and the following tools: scour, rsvg-convert, optipng and pngquant.

@lolodomo lolodomo added the iconset openHAB icon collection label Mar 7, 2023
@lolodomo
Copy link
Contributor

Noone has a Linux DEV env to try to run the convert script (after installing the different required tools) ?
Just to check if it fixes the player.png file ?

@mueller-ma
Copy link
Member Author

Actually you need Docker to run the script: https://github.com/openhab/openhab-webui/blob/main/bundles/org.openhab.ui.iconset.classic/Dockerfile#L6

This way the tool versions are independent of the developer machine and the outcome should always be the same.

@lolodomo lolodomo mentioned this issue Sep 16, 2023
Closed
lolodomo added a commit to lolodomo/openhab-webui that referenced this issue Sep 23, 2023
@lolodomo
Remove PNG icons from the classic icon set
82331cd 
The docker environment is (unfortunately) kept. It can be used to
compress SVG files. Conversion from SVG into PNG format has been
commented in the script .convert.sh.

Closes openhab#2071
Closes openhab#1768

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo mentioned this issue Sep 23, 2023
Merged
kaikreuzer pushed a commit that referenced this issue Nov 13, 2023
@lolodomo
Remove PNG icons from the classic icon set (#2084)
dfbdcf2 
The docker environment is (unfortunately) kept. It can be used to
compress SVG files. Conversion from SVG into PNG format has been
commented in the script .convert.sh.

Closes #2071
Closes #1768

Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working iconset openHAB icon collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove PNG icons from the classic icon set lolodomo/openhab-webui
2 participants
@lolodomo @mueller-ma