Semantic Tag improvements: support tag attributes, tag lookup, and adding tags #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccutrer
reviewed
Apr 14, 2023
jimtng
force-pushed
the
semantics-add
branch
4 times, most recently
from
7275e25 to
779d8cd
Compare
Signed-off-by: Jimmy Tanagra <[email protected]>
jimtng
force-pushed
the
semantics-add
branch
2 times, most recently
from
c1d43c1 to
3a241de
Compare
ccutrer
requested changes
Apr 15, 2023
jimtng
force-pushed
the
semantics-add
branch
2 times, most recently
from
cedfaf2 to
76ed5ab
Compare
ccutrer
reviewed
Apr 15, 2023
Signed-off-by: Jimmy Tanagra <[email protected]>
Signed-off-by: Jimmy Tanagra <[email protected]>
Signed-off-by: Jimmy Tanagra <[email protected]>
ccutrer
reviewed
Apr 15, 2023
jimtng
changed the title
Signed-off-by: Jimmy Tanagra <[email protected]>
ccutrer
approved these changes
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main feature has been merged into core openhab/openhab-core#3519
It may not make it into snapshot until later today.