allow creating custom semantic tags #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimtng
force-pushed
the
custom-semantics
branch
3 times, most recently
from
7680367 to
429afbd
Compare
|
I'm still not 100% on the naming either. |
jimtng
force-pushed
the
custom-semantics
branch
2 times, most recently
from
37453ba to
3a20e56
Compare
|
renamed to |
jimtng
force-pushed
the
custom-semantics
branch
5 times, most recently
from
9dd9274 to
1b8839e
Compare
jimtng
force-pushed
the
custom-semantics
branch
4 times, most recently
from
8864ec6 to
a17516f
Compare
Signed-off-by: Jimmy Tanagra <[email protected]>
|
Replaced by #55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue regarding the parent id, but mitigated in the library openhab/openhab-core#3511
That PR also fixes the synonym search.
Unfortunately I have to do the testing in cucumber. The classloader in rspec doesn't have the defineClass method for some reason.