Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update californium dependencies to version 1.0.7 #475

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

cweitkamp
Copy link
Contributor

Closes openhab/openhab2-addons#4733

Signed-off-by: Christoph Weitkamp [email protected]

@maggu2810
Copy link
Contributor

The bump itself is okay from my side.

But I have a more general question:
Should stuff that is not be used by the framework itself be part of the feature that is provided by the framework -- so its target platform?
Wouldn't it make sense that a framework does not know about stuff it does not use?
Bundles and so features can depend / inject the stuff that is needed without any framework modification.

@kaikreuzer
Copy link
Member

Wouldn't it make sense that a framework does not know about stuff it does not use?

Actually, the Californium lib is our API for CoAP, i.e. it is the content of the "openhab-core-io-transport-coap" feature, which is defined by the framework, similar to e.g. "openhab-core-io-transport-mdns". The only difference is that we do not (yet?) provide any additional code as a bundle with it, so the feature only contains the external lib. Nonetheless, it is what the framework provides and thus I think it is ok to have it here.

What makes it a bit awkward right now is that only the Tradfri binding makes use of it - but hopefully, we will see other add-ons in future and then all should be fine.

@kaikreuzer kaikreuzer merged commit be829d6 into openhab:master Jan 28, 2019
@cweitkamp cweitkamp deleted the feature-californium-update branch January 29, 2019 07:11
@wborn wborn added this to the 2.5 milestone Feb 28, 2019
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants