[Tradfri] Force session resume after communication errors #4764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cweitkamp
reviewed
Jan 31, 2019
| @@ -340,6 +340,15 @@ private synchronized void requestDeviceDetails(String instanceId) { | |||
|
|
|||
| @Override | |||
| public void setStatus(ThingStatus status, ThingStatusDetail statusDetail) { | |||
|
|
|||
There was a problem hiding this comment.
Please remove this empty line.
As discussed in eclipse-archived/smarthome#6065 the tradfri gateway does not support a session resumption after a gateway reboot or other communcation errors. Californium 1.0.7 is able to force a full handshake instead. This change calls "forceResumeSessionFor" after a communication error, so that a full handshake is done. Signed-off-by: Holger Reichert <[email protected]>
hreichert
force-pushed
the
tradfri-forceResumeSession
branch
from
d6b10c2
to
43d52cd
Compare
|
Empty line removed. Offtopic: Is "squashing after review" still the correct procedure? The openhab-distro/CONTRIBUTING.md is not clear about this topic. |
|
Thanks.
No, not for small changes like this. We are able to and will do that while merging. |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Jun 19, 2019
As discussed in eclipse-archived/smarthome#6065 the tradfri gateway does not support a session resumption after a gateway reboot or other communcation errors. Californium 1.0.7 is able to force a full handshake instead. This change calls "forceResumeSessionFor" after a communication error, so that a full handshake is done. Signed-off-by: Holger Reichert <[email protected]> Signed-off-by: Pshatsillo <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
As discussed in eclipse-archived/smarthome#6065 the tradfri gateway does not support a session resumption after a gateway reboot or other communcation errors. Californium 1.0.7 is able to force a full handshake instead. This change calls "forceResumeSessionFor" after a communication error, so that a full handshake is done. Signed-off-by: Holger Reichert <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
|
The reported issue persists. Is there any recommendation? |
Open a new ticket with the details of the problem you're seeing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in eclipse-archived/smarthome#6065 the tradfri gateway does not support a session resumption after a gateway reboot or other communcation errors.
@boaks implemented changes in californium scandium:
Californium 1.0.7 is able to force a full handshake instead.
This change calls "forceResumeSessionFor" after a communication error, so that a full handshake is done.
Related discussion: eclipse-archived/smarthome#6065 (comment)
Californium 1.0.7 version bump: openhab/openhab-core#475