[scale] NPE in ScaleTransformationService

[DerOetzi]

Fix #8011 and #8123

Signed-off-by: Johannes DerOetzi Ott [email protected]

[TravisBuddy]

Travis tests were successful

Hey @DerOetzi,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[kaikreuzer]

Are you sure that the null value is the entry.getKey())? I'd thin it is actually the result of the filter(...) call and thus the findFirst() call causes the NPE.

[J-N-K]

The key is null:

openhab-addons/bundles/org.openhab.transform.scale/src/main/java/org/openhab/transform/scale/internal/ScaleTransformationService.java

Line 167 in 1ad2d6a

data.put(null, value);

.findFirst will return an empty Optional if no value is found.

[kaikreuzer]

Oh, pretty unexpected, but thanks for pointing this out! Then the fix should be alright, I guess.

[kaikreuzer]

But I leave the final decision & merge to you, @J-N-K as you already helped on the investigation.

[J-N-K]

I can't judge whether adding NaN to the scale-file makes sense or not. My original implementation was rejected because the scale-file I introduced for the was not considered useful. So this should be merged by someone who uses humidex-scale.

[DerOetzi]

I can't judge whether adding NaN to the scale-file makes sense or not. My original implementation was rejected because the scale-file I introduced for the was not considered useful. So this should be merged by someone who uses humidex-scale.

@cpmeister and @clinique you had comments on this at #8013 can you please have a look!